Allow eml_file_path in SendEmail and append body google style

[CTY-git]

PR Checklist

• The commit message follows our guidelines: Code of conduct
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Does this PR introduce a breaking change?
• Include PR in release notes?

PR Type

• Bugfix
• Feature
• Refactoring
• Build /CI
• Documentation
• Others

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

[patched-admin]

File Changed: patchwork/steps/ReadEmail/ReadEmail.py

Details: The code modification introduces a potential bug by replacing the += operator with = and adding a break statement. This changes the behavior from concatenating all email body contents to only using the first email body content and discarding the rest.

Affected Code Snippet:

for body in email_data.body:
    rv["body"] = body.content
    break

Start Line: 103
End Line: 105

File Changed: patchwork/steps/ReadEmail/typed.py

Rule 1: Do not ignore potential bugs in the code

Details: Removing the 'content' field from the Attachment TypedDict could lead to potential bugs if any code is relying on this field. The removal of a required field without proper deprecation or migration strategy might cause runtime errors.

Affected Code Snippet:

class Attachment(TypedDict):
    path: str
-    content: str

Start Line: 13
End Line: 15

File Changed: patchwork/steps/SendEmail/SendEmail.py

Rule 1: Do not ignore potential bugs in the code

Details: There is a potential bug in error handling. The code doesn't handle SMTP connection failures or authentication errors gracefully. Also, the mailserver connection is not properly closed using a context manager or try-finally block.

Affected Code Snippet:

smtp_clazz = smtplib.SMTP
if self.is_ssl:
    smtp_clazz = smtplib.SMTP_SSL
with smtp_clazz(self.smtp_host, self.smtp_port) as mailserver:
    mailserver.login(self.smtp_username, self.smtp_password)
    mailserver.send_message(msg)

Start Line: 46
End Line: 52

---

Rule 2: Do not overlook possible security vulnerabilities

Details: The code introduces a potential security vulnerability by rendering user-provided template values without sanitization. The mustache_render function is called with unsanitized input from email_template_value, which could lead to template injection attacks.

Affected Code Snippet:

email_template_value = inputs.get("email_template_value", dict())
self.subject = mustache_render(inputs.get("subject", "Patchwork Execution Email"), email_template_value)
self.body = mustache_render(inputs.get("body", "Patchwork Execution Email"), email_template_value)

Start Line: 25
End Line: 27

File Changed: patchwork/steps/SendEmail/typed.py

Rule 1: Do not ignore potential bugs in the code

Details: Type mismatch potential bug identified with is_smtp_ssl parameter. The parameter is typed as str but should likely be bool based on its name and typical SMTP configuration usage.

Affected Code Snippet:

    is_smtp_ssl: str

Start Line: 20
End Line: 20

---

Rule 2: Do not overlook possible security vulnerabilities

Details: The addition of reply_eml_file_path parameter with is_path=True configuration could potentially lead to path traversal vulnerabilities if not properly sanitized. File paths should be validated before use to prevent unauthorized access to system files.

Affected Code Snippet:

    reply_eml_file_path: Annotated[str, StepTypeConfig(is_path=True)]

Start Line: 21
End Line: 21