Added confirmation step with warning message if there are already existing procuration requests in the database with the same email address. #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhamon
force-pushed
the
bugfix-procuration-uniqueness
branch
2 times, most recently
from
fdd5139 to
9cb873b
Compare
hhamon
force-pushed
the
bugfix-procuration-uniqueness
branch
2 times, most recently
from
d5a4f01 to
7f45580
Compare
mykiwi
suggested changes
Apr 10, 2017
| @@ -101,13 +101,20 @@ | |||
| {{ form_errors(form.emailAddress) }} | |||
| </div> | |||
|
|
|||
| {{ form_rest(form) }} | |||
| {% for warning in form.vars['warnings'] %} | |||
There was a problem hiding this comment.
what about form.vars.warnings ?
| { | ||
| $this->repository = $repository; | ||
| } | ||
|
|
||
| public function buildForm(FormBuilderInterface $builder, array $options) |
| return; | ||
| } | ||
|
|
||
| // In case of on or more existing procurations with the same email |
| return; | ||
| } | ||
|
|
||
| // In case of on or more existing procurations with the same email |
| return; | ||
| } | ||
|
|
||
| // In case, this is a new procuration request, we must determine whether |
There was a problem hiding this comment.
In case of a new procuration request ?
| } | ||
| } | ||
|
|
||
| public function buildView(FormView $view, FormInterface $form, array $options) |
| } | ||
| } | ||
|
|
||
| $view->vars['errors'] = new FormErrorIterator($form, $errors); | ||
| } | ||
|
|
||
| public function configureOptions(OptionsResolver $resolver) |
hhamon
force-pushed
the
bugfix-procuration-uniqueness
branch
from
7f45580 to
5813ea1
Compare
… already existing procuration requests in the database with the same email address.
hhamon
force-pushed
the
bugfix-procuration-uniqueness
branch
from
5813ea1 to
0dc9629
Compare
mykiwi
approved these changes
Apr 10, 2017
HeahDude
reviewed
Apr 10, 2017
| { | ||
| $request = $event->getData(); | ||
| if (!is_array($request)) { | ||
| throw new UnexpectedTypeException($request, 'array'); |
There was a problem hiding this comment.
Please use a TranformationFailedException in submit related events so the client gets an error and not a 500.
HeahDude
reviewed
Apr 10, 2017
| } | ||
|
|
||
| if (!in_array($request['state'], ['new_request', 'must_confirm', 'confirmed'])) { | ||
| throw new RuntimeException('Invalid value for the "state" field.'); |
HeahDude
reviewed
Apr 10, 2017
| $builder->addEventListener(FormEvents::PRE_SUBMIT, [$this, 'onPreSubmit']); | ||
| } | ||
|
|
||
| public function onPreSubmit(FormEvent $event): void |
There was a problem hiding this comment.
This should not be public.
HeahDude
reviewed
Apr 10, 2017
| // In case of a new procuration request, we must determine whether or | ||
| // not there are already existing procuration requests with the same | ||
| // email address. If yes, the user will have to confirm his choice. | ||
| if ('new_request' === $request['state']) { |
There was a problem hiding this comment.
Why don't you use constants?
HeahDude
reviewed
Apr 10, 2017
|
|
||
| public function buildView(FormView $view, FormInterface $form, array $options): void | ||
| { | ||
| parent::buildView($view, $form, $options); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.