Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added admin Event type crud #1086

Merged
merged 6 commits into from
May 22, 2017
Merged

Added admin Event type crud #1086

merged 6 commits into from
May 22, 2017

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented May 6, 2017

No description provided.

* @ORM\Column(type="integer", options={"unsigned": true})
* @ORM\GeneratedValue(strategy="IDENTITY")
*/
protected $id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private ?

Copy link
Contributor

@mykiwi mykiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have a 500 if you try to delete a category which is used.

'_sort_by' => 'name',
];

protected function configureShowFields(ShowMapper $showMapper)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: void

;
}

protected function configureFormFields(FormMapper $formMapper)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: void

;
}

protected function configureListFields(ListMapper $listMapper)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: void

@@ -68,6 +69,11 @@ public function authenticateAsAdherent(Client $client, string $emailAddress, str
return $client->followRedirect();
}

private function getEventCategoryIdForName(string $categoryName): int
{
return (string) $this->manager->getRepository(EventCategory::class)->findOneBy(['name' => $categoryName])->getId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why cast in string?

@mykiwi mykiwi force-pushed the event-type-crud branch from cb1b584 to 54c9147 Compare May 17, 2017 13:42
@mykiwi mykiwi force-pushed the event-type-crud branch from ac38423 to c8ee53c Compare May 17, 2017 14:32
@hhamon
Copy link
Contributor

hhamon commented May 18, 2017

What's the status of this PR?

@mykiwi
Copy link
Contributor

mykiwi commented May 22, 2017

It's ready to merge, but #1123 will be useless (like I said in the trello comment)

@tgalopin
Copy link
Contributor

Let's merge then.

@mykiwi mykiwi merged commit eea698e into master May 22, 2017
@mykiwi mykiwi deleted the event-type-crud branch May 22, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants