-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added admin Event type crud #1086
Conversation
* @ORM\Column(type="integer", options={"unsigned": true}) | ||
* @ORM\GeneratedValue(strategy="IDENTITY") | ||
*/ | ||
protected $id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have a 500 if you try to delete a category which is used.
'_sort_by' => 'name', | ||
]; | ||
|
||
protected function configureShowFields(ShowMapper $showMapper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: void
; | ||
} | ||
|
||
protected function configureFormFields(FormMapper $formMapper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: void
; | ||
} | ||
|
||
protected function configureListFields(ListMapper $listMapper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: void
@@ -68,6 +69,11 @@ public function authenticateAsAdherent(Client $client, string $emailAddress, str | |||
return $client->followRedirect(); | |||
} | |||
|
|||
private function getEventCategoryIdForName(string $categoryName): int | |||
{ | |||
return (string) $this->manager->getRepository(EventCategory::class)->findOneBy(['name' => $categoryName])->getId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cast in string?
What's the status of this PR? |
It's ready to merge, but #1123 will be useless (like I said in the trello comment) |
Let's merge then. |
No description provided.