Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Object data type should not change from beforeSave to afterSave trigger #9177

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

mkmandar123
Copy link
Contributor

@mkmandar123 mkmandar123 commented Jul 5, 2024

Pull Request

Issue

Change in data of the object from beforeSave to afterSave hook.

Closes: #9176

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

parse-github-assistant bot commented Jul 5, 2024

Thanks for opening this pull request!

@mtrezza mtrezza changed the title Bug: Object data type change from beforeSave to afterSave hook trigger. fix: Object data type change from beforeSave to afterSave hook trigger. Jul 8, 2024
@mtrezza mtrezza changed the title fix: Object data type change from beforeSave to afterSave hook trigger. fix: Object data type change from beforeSave to afterSave hook trigger Jul 8, 2024
@mtrezza
Copy link
Member

mtrezza commented Jul 8, 2024

After the recent fixes in Parse Server, let's rebase and see if this test still fails...

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
spec/ParseObject.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza
Copy link
Member

mtrezza commented Jul 8, 2024

Test passes; merging this PR to add the additional test to avoid regression and closing related issue.

@mtrezza mtrezza changed the title fix: Object data type change from beforeSave to afterSave hook trigger test: Object data type should not change from beforeSave to afterSave trigger Jul 8, 2024
@mtrezza mtrezza merged commit 1e21b69 into parse-community:alpha Jul 8, 2024
23 of 24 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jul 9, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object data type change from beforeSave to afterSave hook trigger
3 participants