refactor: Improve incorrect deprecation log message for auth adapter #8347
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Closed
Codecov ReportBase: 94.24% // Head: 94.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## alpha #8347 +/- ##
==========================================
+ Coverage 94.24% 94.25% +0.01%
==========================================
Files 180 180
Lines 13977 13977
==========================================
+ Hits 13172 13174 +2
+ Misses 805 803 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mtrezza
requested review from
dblythy
and removed request for
a team and
dblythy
|
🎉 This change has been released in version 6.0.0-alpha.13 |
|
🎉 This change has been released in version 6.0.0-beta.1 |
|
🎉 This change has been released in version 6.0.0 |
dblythy
pushed a commit
to dblythy/parse-server
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
PR #7953 introduced an incorrect / unclear deprecation message that logs:
The log message should be improved. I think what the message intends to say is that the auth adapter is not enabled but a future version will require to explicitly enable it for it to work.
Closes: #n/a
Approach
Improve log message.
TODOs before merging
n/a