Update OneSignalPushAdapter.js [More Parameters Added for Android]#770
Update OneSignalPushAdapter.js [More Parameters Added for Android]#770mithleshjs wants to merge 1 commit intoparse-community:masterfrom mithleshjs:master
Conversation
| post['url'] = data['uri']; | ||
| } | ||
|
|
||
| if(data['android_background_data']) |
There was a problem hiding this comment.
it would be nicer with a reduce:
post = ['android_background_data', ...].reduce( (post, key) {
if (data[key]) {
post[key] = data[key];
delete data[key];
}
return post;
}, post);
|
@mithleshjs updated the pull request. |
|
@mithleshjs updated the pull request. |
3 similar comments
|
@mithleshjs updated the pull request. |
|
@mithleshjs updated the pull request. |
|
@mithleshjs updated the pull request. |
|
@flovilmart using reduce is causing build to fail and it overrides other params. I think it is best without a reduce. |
|
What do you mean it overrides other params and build is failing? |
|
What I meant was that implementating reduce method as pointed by you is not working correctly. |
|
You mean with the ... ? |
|
I was referring to this note by you.
This method didn't work. |
|
Extra Parameters Added: