-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds deprecator #7303
Adds deprecator #7303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7303 +/- ##
==========================================
- Coverage 93.93% 86.26% -7.67%
==========================================
Files 179 181 +2
Lines 13153 13190 +37
==========================================
- Hits 12355 11379 -976
- Misses 798 1811 +1013
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I changed the log message from
to
This is according to the Node.js deprecation warnings and makes it easier so search log files by term |
@dplewis If there is no objection, I'll merge this later today. The coverage change is actually 0%; just with the last commit it seems that cov is reporting false negatives. |
* adds deprecator * un-fit * added changelog entry * some fixes * un-fit * removed deprecation definition * changed deprecation log syntax according to Nodejs
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Currently, there is no mechanism provided to deprecate Parse Server settings.
Related issue: closes #7302
Approach
Adds a new
Deprecator
in./Deprecator
directory.Features:
./Deprecator/Deprecations.js
in a standardized way tonew ParseServer(...)
)Examples
someFeature
option default will change fromfalse
totrue
:someFeature
option name will change tosomethingElse
:someFeature
option name will be removed:TODOs before merging
[ ] Add changes to documentation (guides, repository pages, in-code descriptions)to be added in Add deprecation policy #7199