Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing __indexBuildCompletionCallbackForTests callback to serverSta… #5577

Closed

Conversation

davimacedo
Copy link
Member

According to the discussion on #5573 this PR changes the name of "__indexBuildCompletionCallbackForTests" callback to "serverStartComplete".

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #5577 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5577   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         129      129           
  Lines        9194     9194           
=======================================
  Hits         8646     8646           
  Misses        548      548
Impacted Files Coverage Δ
src/Options/index.js 100% <ø> (ø) ⬆️
src/ParseServer.js 96.35% <100%> (ø) ⬆️
src/RestWrite.js 93.54% <0%> (-0.18%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c9728...db5701f. Read the comment docs.

@ghost
Copy link

ghost commented May 10, 2019

Danger run resulted in 1 fail; to find out more, see the checks page.

Generated by 🚫 dangerJS

@davimacedo davimacedo force-pushed the serverStartComplete branch 2 times, most recently from 329eac3 to b53a0ec Compare May 10, 2019 09:22
@dplewis
Copy link
Member

dplewis commented May 10, 2019

@davimacedo Is this PR needed? Looks like you covered most of this in your other PR.

@davimacedo
Copy link
Member Author

davimacedo commented May 10, 2019

I was not really sure if the other PRs were according to @acinader 's ideas and that's why I sent the three of them so we can choose which to merge and close the others. serverStartComplete < avoidUnhandledPromiseRejection < removeTestDelays. If we decide to go with the last one (removeTestDelays), we can just close the others.

@davimacedo davimacedo closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants