Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #5207 #5257

Merged
merged 2 commits into from
Dec 24, 2018
Merged

Fix for #5207 #5257

merged 2 commits into from
Dec 24, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 22, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2018 •
edited
Loading

Codecov Report

Merging #5257 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5257      +/-   ##
==========================================
- Coverage    93.9%   93.88%   -0.03%     
==========================================
  Files         123      123              
  Lines        8968     8971       +3     
==========================================
+ Hits         8421     8422       +1     
- Misses        547      549       +2
Impacted Files Coverage Δ
src/LiveQuery/ParseLiveQueryServer.js 87.57% <100%> (+0.11%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.48% <0%> (-0.73%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.15% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9aff79...2c43674. Read the comment docs.

acinader
acinader approved these changes Dec 22, 2018
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and easy.

@dplewis dplewis merged commit 9969892 into parse-community:master Dec 24, 2018
@dplewis dplewis deleted the livequery-hidden branch December 24, 2018 01:41
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis
Fix for #5207 (parse-community#5257)
9ab3fff
@parseplatformorg parseplatformorg mentioned this pull request Jun 2, 2023
Closed
@kiarza2543 kiarza2543 mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

@flovilmart flovilmart flovilmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @flovilmart @acinader