Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle return values in beforeSave #5228

Merged
merged 7 commits into from
Mar 14, 2019
Merged

Properly handle return values in beforeSave #5228

merged 7 commits into from
Mar 14, 2019

Commits on Dec 6, 2018

  1. added failing test case to CloudCode.spec.js 

    a possible bug found where beforeSave does not apply changes to request
object if the beforeSave hook ends with 'true' returned
    @blastoy
    blastoy committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    ec1b130 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. moddified triggers to return null when beforeSave 

    also changed test cases to be more descriptive + added extra test case that returns promise in the beforeSave
    @blastoy
    blastoy committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    a776de4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into beforeSave-return-failing-test

    @blastoy
    blastoy authored Dec 14, 2018
    Configuration menu
    Copy the full SHA
    626adb6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. address original issue

    @dplewis
    dplewis committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    e01c57d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Revert "address original issue" 

    This reverts commit e01c57d.
    @dplewis
    dplewis committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    aa9c57e View commit details
    Browse the repository at this point in the history

  2. fix promises and tests

    @dplewis
    dplewis committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    57249f0 View commit details
    Browse the repository at this point in the history

  3. Add a test to verify that a failed beforeChange hook will 

    prevent updating the object.
    @acinader
    acinader committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    16e947b View commit details
    Browse the repository at this point in the history