-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow throw native Error in beforeSave hook #5064
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5064 +/- ##
==========================================
+ Coverage 93.75% 93.78% +0.02%
==========================================
Files 122 122
Lines 8857 8859 +2
==========================================
+ Hits 8304 8308 +4
+ Misses 553 551 -2
Continue to review full report at Codecov.
|
LGTM! Thanks! |
@flovilmart Maybe we should not wrap thrown exception on Lines 563 to 577 in 91f121e
|
I’m not sure I understand what you mean. |
@flovilmart I mean we should convert whatever user's |
That seems reasonable |
this fixes: #5063 |
No description provided.