Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth module refactoring in order to be reusable #4940

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Conversation

flovilmart
Copy link
Contributor

The Auth module can be reused in other parts in order to get a user and its roles based upon it's sessionToken (ie liveQuery and #4926 which needs a new users / roles cache).

Now it supports initialization without a ParseServer Config / cache so it can be reused in standalone, just simply with an initialized Parse SDK.

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #4940 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4940      +/-   ##
==========================================
- Coverage   92.94%   92.92%   -0.03%     
==========================================
  Files         119      119              
  Lines        8836     8858      +22     
==========================================
+ Hits         8213     8231      +18     
- Misses        623      627       +4
Impacted Files Coverage Δ
src/Auth.js 100% <100%> (ø) ⬆️
src/Adapters/Auth/meetup.js 84.21% <0%> (-5.27%) ⬇️
src/RestWrite.js 93.14% <0%> (-0.37%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.2% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d91c10...cf5c32c. Read the comment docs.

@flovilmart flovilmart mentioned this pull request Aug 8, 2018
@acinader
Copy link
Contributor

acinader commented Aug 9, 2018

well, this answers my question in #4387 about why config or not and why use the rest controller if we have a config. got it. so this looks good to me with the comments in #4387

acinader
acinader previously approved these changes Aug 9, 2018
@flovilmart flovilmart merged commit 2ae6035 into master Aug 9, 2018
@flovilmart flovilmart deleted the auth-refactor branch August 9, 2018 17:02
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Auth module refactoring in order to be reusable

* Ensure cache controller is properly forwarded from helpers

* Nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants