Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for objectIdSize #4526

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Added docs for objectIdSize #4526

merged 1 commit into from
Feb 16, 2018

Conversation

jcguarinpenaranda
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2018

Codecov Report

Merging #4526 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4526      +/-   ##
==========================================
- Coverage   92.89%   92.83%   -0.06%     
==========================================
  Files         118      118              
  Lines        8445     8445              
==========================================
- Hits         7845     7840       -5     
- Misses        600      605       +5
Impacted Files Coverage Δ
src/Adapters/Cache/InMemoryCache.js 91.66% <0%> (-8.34%) ⬇️
src/RestWrite.js 93.46% <0%> (-0.37%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.12% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550b69e...ec589a4. Read the comment docs.

@steven-supersolid
Copy link
Contributor

Should perhaps add a note about what the default is if omitted

@jcguarinpenaranda
Copy link
Contributor Author

jcguarinpenaranda commented Jan 29, 2018 via email

@milesrichardson
Copy link

Be careful setting objectIdSize to non-default values. There are a few side effects, see here: #4363

@flovilmart
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants