Refactor pushStatusHandler to use Parse instead of direct access #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4173 +/- ##
==========================================
+ Coverage 92.13% 92.21% +0.07%
==========================================
Files 116 116
Lines 8044 8075 +31
==========================================
+ Hits 7411 7446 +35
+ Misses 633 629 -4
Continue to review full report at Codecov.
|
flovilmart
changed the title
natanrolnik
approved these changes
Sep 18, 2017
acinader
approved these changes
Sep 18, 2017
| @@ -127,6 +127,7 @@ describe('Parse.Push', () => { | |||
| alert: 'Hello world!' | |||
| } | |||
| }, {useMasterKey: true})) | |||
| .then(() => delayPromise(500)) | |||
There was a problem hiding this comment.
can these be any shorter?
There was a problem hiding this comment.
nope, not really, because we don't wait till it's completed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intended use? Forward analytics with _PushStatus
Worth noting: when using the experimental direct access, this is pretty much 0 overhead.