Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-3789 #3793

Merged
merged 2 commits into from
May 11, 2017
Merged

fix-3789 #3793

merged 2 commits into from
May 11, 2017

Conversation

youngerong
Copy link
Contributor

Log print password clearly, fix it. Issue: #3789

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice. Could you please add a unit test? If you take a look at CloudCodeLogger.spec.js "trigger should obfuscate password" would probably be a good example?

@codecov
Copy link

codecov bot commented May 9, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8d67776). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3793   +/-   ##
=========================================
  Coverage          ?   90.08%           
=========================================
  Files             ?      114           
  Lines             ?     7543           
  Branches          ?        0           
=========================================
  Hits              ?     6795           
  Misses            ?      748           
  Partials          ?        0
Impacted Files Coverage Δ
src/Controllers/LoggerController.js 88.88% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d67776...a76ecb9. Read the comment docs.

@flovilmart
Copy link
Contributor

@youngerong we'd love to make a release today with your fix in, do you think you can add the relevant unit tests?

@youngerong
Copy link
Contributor Author

@flovilmart Yes. I have added one relevant unit test.

@flovilmart
Copy link
Contributor

Thanks!

@flovilmart flovilmart dismissed acinader’s stale review May 11, 2017 11:16

All good with the added test

@flovilmart flovilmart merged commit e0be653 into parse-community:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants