Some `databaseOptions` that are valid MongoDB options are marked as invalid

[pocketcolin]

New Issue Checklist

• Report security issues confidentially.
• Any contribution is under this license.
• Before posting search existing issues.

Issue Description

I'm pretty much just adding onto issue #9211 with this issue and already have a PR to address it. There are lots of Mongo config options, but because Parse 7 now validates server config keys we now need to hardcode those options so they pass validation.

Steps to reproduce

const config = {
  ...,
  databaseOptions: {
    connectTimeoutMS: 1000,
    socketTimeoutMS: 1000,
    minPoolSize: 10,
  }
}

Actual Outcome

Error logged:

error: Invalid Option Keys Found: databaseOptions.connectTimeoutMS, databaseOptions.socketTimeoutMS, databaseOptions.minPoolSize

Expected Outcome

No error logged, as these are all valid keys.

Environment

Server

• Parse Server version: 7.4.0

[parse-github-assistant]

Thanks for opening this issue!

• 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

[mtrezza]

What's your suggestion? That we remove the validation completely?

I don't see much purpose in validating the DB options, as they are not exposed and the MongoDB driver would throw an error anyway. Just instead of the driver throwing the error, Parse Server throws it beforehand. Doesn't seem necessary, and only keeps the burden of maintaining the options list, which probably doesn't make much sense anyway since the options may change depending on the MongoDB (driver) version and we don't consider that in the validation.

Edit: re-reading #9211 I remember why validation wasn't removed, as some Parse Server options are hidden in the MongoDB driver options. Now would be a good time to consider separating these custom option from MongoDB native options, and then remove validation all together.

[pocketcolin]

@mtrezza yeah sorry I removed my previous comment because I re-read #9211 and understood why you made that decision orignally. I would completely agree that in an ideal world we'd have a separate config for mongo connection settings that wasn't intermixed with parse server config and then we could remove mongo config validation altogether. I doubt that's something I'd have time for in the near future, but I'm happy to look at it when I have time.

[mtrezza]

Let's see, we'll take a look; if it's more work we can just add the option for now and merge your PR.

[dblythy]

Seems like:

enableSchemaHooks is a Parse Server database options and has application behaviour
schemaCacheTtl is a Parse Server option and has application behaviour

maxTimeMS is a db option but has application behaviour

maxPoolSize gets passed directly to the db
maxStalenessSeconds gets passed directly to the db
retryWrites is a db option

So there are really only 3 properties that actually_ have a Parse Server config.

Does it make sense to distinguish as:

• databaseOptions and databaseAdapterOptions
• databaseApplicationOptions and databaseConnectionOptions
• parseDatabaseOptions and rawDatabaseOptions
• databaseConfig and databaseDriverConfig

[mtrezza]

Does it make sense to distinguish as:

databaseOptions and databaseAdapterOptions
databaseApplicationOptions and databaseConnectionOptions
parseDatabaseOptions and rawDatabaseOptions
databaseConfig and databaseDriverConfig

What do you mean?

[pocketcolin]

@mtrezza this is a bit of a blocker for us to upgrade to Parse 7. Think we can go ahead and get my PR merged?

[mtrezza]

@pocketcolin, the PR has been merged and released as Parse Server 8.0.0-alpha.7 (stable release expected in a few days). This feature won't be automatically added to Parse Server 7. If you need this feature in Parse Server 7 as well, please feel fee to open another PR against the LTS branch release-7.x.x. Just a note that for technical reasons there won't be a Parse Server 7 release before the Parse Server 8 stable release.

[pocketcolin]

@mtrezza oops I totally missed that 🤦 Thanks for pointing out the 7 v 8 branches. I just created a new PR (#9577) pointing at release-7.x.x.