Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: databaseOptions missing in Parse Server Options docs #8168

Closed
mtrezza opened this issue Sep 13, 2022 · 14 comments · Fixed by #8173
Closed

docs: databaseOptions missing in Parse Server Options docs #8168

mtrezza opened this issue Sep 13, 2022 · 14 comments · Fixed by #8173
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version type:docs Only change in the docs or README

Comments

@mtrezza
Copy link
Member

mtrezza commented Sep 13, 2022

The databaseOptions are not documented in the Parse Server docs. Instead it's just an Any type.

The correcting approach is to add a new Type and specify all the databaseOptions in that new type. See for example the Pages option.

This is a crucial part of the documentation for everyone who is using multiple Parse Server instances, e.g. behind a load balancer. The databaseOptions.enableSchemaHooks option is an essential configuration, see #7214.

@mtrezza mtrezza added type:bug Impaired feature or lacking behavior that is likely assumed type:docs Only change in the docs or README and removed type:bug Impaired feature or lacking behavior that is likely assumed labels Sep 13, 2022
@dblythy
Copy link
Member

dblythy commented Sep 14, 2022

@mtrezza
Copy link
Member Author

mtrezza commented Sep 14, 2022

Ha! I must have looked at an old API version. Are there other DB options missing?

If any custom options are just passed to the adapter, we don't need to document them. But if supported options are explicitly defined, we should document them all.

@dblythy
Copy link
Member

dblythy commented Sep 14, 2022

I'm pretty sure databaseOptions can be any valid options that can be passed to Mongo, Postgres, or any other valid database adapter

@mtrezza
Copy link
Member Author

mtrezza commented Sep 14, 2022

Do we have any other custom options, like enableSchemaHooks which is something we invented and is not passed to the DB adapter.

@dblythy
Copy link
Member

dblythy commented Sep 14, 2022

I think maxTimeMS, but that is for the mongo adapter only. There might be other options but I think that's all I can find

@mtrezza
Copy link
Member Author

mtrezza commented Sep 14, 2022

So this issue can actually be closed then? Maybe we should add to the docs somewhere that any other parameter is passed directly to the DB client? In any case, this issue belongs to the parse-server repo, because the API docs are generated from the definition files, right?

@dblythy
Copy link
Member

dblythy commented Sep 14, 2022

I think it can stay open but transferred, it would help to explain to users that any other database options get passed directly to the db client

@mtrezza
Copy link
Member Author

mtrezza commented Sep 14, 2022

OK, I'll transfer this to Parse Server and maybe you can do a PR to somehow add that note to the API docs, then we can close this.

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@mtrezza mtrezza transferred this issue from parse-community/docs Sep 14, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.27

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version type:docs Only change in the docs or README
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants