Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Relay version >=0.8.0 introduce ID compatibility issue (objectIdSize higher than 19) #7622

Closed
4 tasks done
Moumouls opened this issue Oct 13, 2021 · 9 comments · Fixed by #7627 or #7722
Closed
4 tasks done
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@Moumouls
Copy link
Member

Moumouls commented Oct 13, 2021

New Issue Checklist

Issue Description

With an objectId size setting equal or hight than 20 graphql request with an Mongo objectID fails (Invalid code point issue from graphql relay).

Steps to reproduce

Start a server, set objectIdSize to 20, create an object on graphql api, and the mutation return get the objectId and the id (relay). query the graphql api with the objectId. Request will fail.

Actual Outcome

All request fail using a non relay id

Expected Outcome

Non relay id from any size should works

Environment

Parse server with graphql relay >= 0.8.0
5.0.0-alpha.1

graphql-relay should be downgraded to 0.7.0

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2021

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@Moumouls
Copy link
Member Author

A developer with an objectId size higher than 19 need to downgrade parse-server AND SHOULD NOT update his objectID size.

After the parse PR i'll open an issue on graphql-relay to understand what is going wrong with core ID of size 20

@Moumouls Moumouls added severity:medium type:bug Impaired feature or lacking behavior that is likely assumed labels Oct 13, 2021
@Moumouls Moumouls changed the title GraphQL: Relay version introduce compatibility ID base 64 issue from version 0.8.0 GraphQL: Relay version >=0.8.0 introduce ID compatibility issue (objectIdSize higher than 19) Oct 13, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021

To which versions of Parse Server does that currently apply?

@Moumouls
Copy link
Member Author

5.0.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 27, 2021
@mtrezza mtrezza reopened this Nov 27, 2021
@mtrezza mtrezza added block:beta Needs to be resolved before next release on beta branch; remove label afterwards block:release Needs to be resolved before next release on release branch; remove label afterwards labels Nov 27, 2021
@parse-github-assistant
Copy link

The label block:release cannot be used in combination with block:beta.

@parse-github-assistant parse-github-assistant bot removed the block:release Needs to be resolved before next release on release branch; remove label afterwards label Nov 27, 2021
@mtrezza mtrezza removed the block:beta Needs to be resolved before next release on beta branch; remove label afterwards label Feb 12, 2022
@mtrezza
Copy link
Member

mtrezza commented Feb 12, 2022

Closing, via #7627 (merged into alpha), #7722 (merged into beta).

@mtrezza mtrezza closed this as completed Feb 12, 2022
@mtrezza mtrezza added the state:released-beta Released as beta version label Feb 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
3 participants