Add cloudFunctionError

Author: alljinx

spec/CloudCodeLogger.spec.js

@@ -183,24 +183,39 @@ describe('Cloud Code Logger', () => {
   });
 
   it('should log cloud function execution using the custom log level', async done => {
+    Parse.Cloud.define('aFunction', () => {
+      return 'it worked!';
+    });
+
+    Parse.Cloud.define('bFunction', () => {
+      throw new Error('Failed');
+    });
+
+    await Parse.Cloud.run('aFunction', { foo: 'bar' }).then(() => {
+      const log = spy.calls.allArgs().find(log => log[1].startsWith('Ran cloud function '))?.[0];
+      expect(log).toEqual('info');
+    });
+
     await reconfigureServer({
       silent: true,
       logLevels: {
-        cloudFunctionRan: 'warn',
+        cloudFunctionSuccess: 'warn',
+        cloudFunctionError: 'info',
       },
     });
 
-    Parse.Cloud.define('aFunction', () => {
-      return 'it worked!';
-    });
-
     spy = spyOn(Config.get('test').loggerController.adapter, 'log').and.callThrough();
 
-    Parse.Cloud.run('aFunction', { foo: 'bar' }).then(() => {
-      const log = spy.calls.allArgs().find(log => log[1].startsWith('Ran cloud function '))?.[0];
-      expect(log).toEqual('warn');
+    try {
+      await Parse.Cloud.run('bFunction', { foo: 'bar' });
+      throw new Error('bFunction should have failed');
+    } catch {
+      const log = spy.calls
+        .allArgs()
+        .find(log => log[1].startsWith('Failed running cloud function bFunction for '))?.[0];
+      expect(log).toEqual('info');
       done();
-    });
+    }
   });
 
   it('should log cloud function triggers using the custom log level', async () => {

src/Options/Definitions.js

@@ -993,9 +993,14 @@ module.exports.AuthAdapter = {
   },
 };
 module.exports.LogLevels = {
-  cloudFunctionRan: {
-    env: 'PARSE_SERVER_LOG_LEVELS_CLOUD_FUNCTION_RAN',
-    help: 'Log level used by the Cloud Code Functions. Default is `info`.',
+  cloudFunctionError: {
+    env: 'PARSE_SERVER_LOG_LEVELS_CLOUD_FUNCTION_ERROR',
+    help: 'Log level used by the Cloud Code Functions on error. Default is `error`.',
+    default: 'error',
+  },
+  cloudFunctionSuccess: {
+    env: 'PARSE_SERVER_LOG_LEVELS_CLOUD_FUNCTION_SUCCESS',
+    help: 'Log level used by the Cloud Code Functions on success. Default is `info`.',
     default: 'info',
   },
   triggerAfter: {

src/Options/docs.js

@@ -577,8 +577,12 @@ export interface LogLevels {
   :DEFAULT: error
   */
   triggerBeforeError: ?string;
-  /* Log level used by the Cloud Code Functions. Default is `info`.
+  /* Log level used by the Cloud Code Functions on success. Default is `info`.
   :DEFAULT: info
   */
   cloudFunctionSuccess: ?string;
+  /* Log level used by the Cloud Code Functions on error. Default is `error`.
+  :DEFAULT: error
+  */
+  cloudFunctionError: ?string;
 }

src/Options/index.js

@@ -140,7 +140,7 @@ export class FunctionsRouter extends PromiseRouter {
         result => {
           try {
             const cleanResult = logger.truncateLogMessage(JSON.stringify(result.response.result));
-            logger[req.config.logLevels.cloudFunctionRan](
+            logger[req.config.logLevels.cloudFunctionSuccess](
               `Ran cloud function ${functionName} for user ${userString} with:\n  Input: ${cleanInput}\n  Result: ${cleanResult}`,
               {
                 functionName,
@@ -155,7 +155,7 @@ export class FunctionsRouter extends PromiseRouter {
         },
         error => {
           try {
-            logger.error(
+            logger[req.config.logLevels.cloudFunctionError](
               `Failed running cloud function ${functionName} for user ${userString} with:\n  Input: ${cleanInput}\n  Error: ` +
                 JSON.stringify(error),
               {