Skip to content

Commit b71c7d8

Browse files
committed
fix: feedbacks
1 parent 5087a15 commit b71c7d8

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

spec/ParseUser.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe('Parse.User testing', () => {
8282
});
8383

8484
it('logs username taken with configured log level', async () => {
85-
await reconfigureServer({ logLevels: { usernameAlreadyExists: 'warn' } });
85+
await reconfigureServer({ logLevels: { signupUsernameTaken: 'warn' } });
8686
const logger = require('../lib/logger').default;
8787
loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
8888
const loggerWarnSpy = spyOn(logger, 'warn').and.callThrough();
@@ -110,7 +110,7 @@ describe('Parse.User testing', () => {
110110
});
111111

112112
it('can silence username taken log event', async () => {
113-
await reconfigureServer({ logLevels: { usernameAlreadyExists: 'silent' } });
113+
await reconfigureServer({ logLevels: { signupUsernameTaken: 'silent' } });
114114
const logger = require('../lib/logger').default;
115115
loggerErrorSpy = spyOn(logger, 'error').and.callThrough();
116116
const loggerWarnSpy = spyOn(logger, 'warn').and.callThrough();

src/Options/Definitions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1506,7 +1506,7 @@ module.exports.LogLevels = {
15061506
'Log level used by the Cloud Code Triggers `beforeSave`, `beforeDelete`, `beforeFind`, `beforeLogin` on success. Default is `info`. See [LogLevel](LogLevel.html) for available values.',
15071507
default: 'info',
15081508
},
1509-
usernameAlreadyExists: {
1509+
signupUsernameTaken: {
15101510
env: 'PARSE_SERVER_LOG_LEVELS_USERNAME_ALREADY_EXISTS',
15111511
help:
15121512
'Log level used when a sign-up fails because the username already exists. Default is `error`. See [LogLevel](LogLevel.html) for available values.',

src/Options/docs.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Options/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,5 +792,5 @@ export interface LogLevels {
792792
/* Log level used when a sign-up fails because the username already exists. Default is `error`. See [LogLevel](LogLevel.html) for available values.
793793
:DEFAULT: error
794794
*/
795-
usernameAlreadyExists: ?string;
795+
signupUsernameTaken: ?string;
796796
}

src/middlewares.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -466,8 +466,8 @@ export function handleParseErrors(err, req, res, next) {
466466
if (req.config && req.config.enableExpressErrorHandler) {
467467
return next(err);
468468
}
469-
const usernameAlreadyExistsLevel =
470-
req.config?.logLevels?.usernameAlreadyExists || 'info';
469+
const signupUsernameTakenLevel =
470+
req.config?.logLevels?.signupUsernameTaken || 'info';
471471
let httpStatus;
472472
// TODO: fill out this mapping
473473
switch (err.code) {
@@ -483,10 +483,10 @@ export function handleParseErrors(err, req, res, next) {
483483
res.status(httpStatus);
484484
res.json({ code: err.code, error: err.message });
485485
if (err.code === Parse.Error.USERNAME_TAKEN) {
486-
if (usernameAlreadyExistsLevel !== 'silent') {
486+
if (signupUsernameTakenLevel !== 'silent') {
487487
const loggerMethod =
488-
typeof log[usernameAlreadyExistsLevel] === 'function'
489-
? log[usernameAlreadyExistsLevel].bind(log)
488+
typeof log[signupUsernameTakenLevel] === 'function'
489+
? log[signupUsernameTakenLevel].bind(log)
490490
: log.error.bind(log);
491491
loggerMethod('Parse error: ', err);
492492
}

types/Options/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,6 @@ export interface LogLevels {
297297
triggerBeforeError?: string;
298298
cloudFunctionSuccess?: string;
299299
cloudFunctionError?: string;
300-
usernameAlreadyExists?: string;
300+
signupUsernameTaken?: string;
301301
}
302302
export {};

0 commit comments

Comments
 (0)