Skip to content

Commit b641554

Browse files
committed
test: revert cloud logger flaky fix attempt
1 parent 3b2508e commit b641554

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

spec/CloudCodeLogger.spec.js

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,6 @@ describe('Cloud Code Logger', () => {
247247
spy = spyOn(Config.get('test').loggerController.adapter, 'log').and.callThrough();
248248
const obj = new Parse.Object('TestClass');
249249
await obj.save();
250-
// Wait for afterSave to complete
251-
await new Promise(resolve => setTimeout(resolve, 100));
252250

253251
return {
254252
beforeSave: spy.calls
@@ -273,7 +271,7 @@ describe('Cloud Code Logger', () => {
273271
});
274272

275273
Parse.Cloud.run('aFunction', { foo: 'bar' })
276-
.catch(() => {})
274+
.catch(() => { })
277275
.then(() => {
278276
const logs = spy.calls.all().reverse();
279277
expect(logs[0].args[1]).toBe('Parse error: ');
@@ -383,34 +381,21 @@ describe('Cloud Code Logger', () => {
383381
triggerBeforeError: 'silent',
384382
},
385383
});
386-
387-
let afterSaveCompleted;
388-
const afterSavePromise = new Promise(resolve => {
389-
afterSaveCompleted = resolve;
390-
});
391-
392384
Parse.Cloud.beforeSave('TestClassError', () => {
393385
throw new Error('Failed');
394386
});
395387
Parse.Cloud.beforeSave('TestClass', () => { });
396-
Parse.Cloud.afterSave('TestClass', async () => {
397-
afterSaveCompleted();
398-
});
388+
Parse.Cloud.afterSave('TestClass', () => { });
399389

400390
spy = spyOn(Config.get('test').loggerController.adapter, 'log').and.callThrough();
401391

402392
const obj = new Parse.Object('TestClass');
403393
await obj.save();
404-
// Wait for afterSave to actually complete
405-
await afterSavePromise;
406-
await new Promise(resolve => setTimeout(resolve, 100));
407394
expect(spy).toHaveBeenCalledTimes(0);
408395

409396
const objError = new Parse.Object('TestClassError');
410397
await expectAsync(objError.save()).toBeRejected();
411-
// Wait for any async error handling to complete
412-
await new Promise(resolve => setTimeout(resolve, 100));
413398
// Not "beforeSave failed for TestClassError for user ..."
414399
expect(spy).toHaveBeenCalledTimes(1);
415400
});
416-
});
401+
});

0 commit comments

Comments
 (0)