Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for metadata and tagging files #83

Merged
merged 3 commits into from
Jan 16, 2020

Conversation

stevestencil
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #83 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   94.54%   94.88%   +0.34%     
==========================================
  Files           2        2              
  Lines         165      176      +11     
  Branches       34       37       +3     
==========================================
+ Hits          156      167      +11     
  Misses          9        9
Impacted Files Coverage Δ
index.js 94.05% <100%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddbfd6...8fa44fb. Read the comment docs.

@natanrolnik
Copy link

@stevestencil this looks interesting!
I looked at the tests, but didn't understand so much how it would work. Would you mind adding to the ReadMe a section about tagging/metadata and how to add them through the API?

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@davimacedo davimacedo merged commit 5bbc7fa into parse-community:master Jan 16, 2020
@davimacedo
Copy link
Member

@stevestencil can you please add some docs like @natanrolnik suggested? Maybe in the notes and/or guide?

@stevestencil
Copy link
Contributor Author

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants