-
-
Notifications
You must be signed in to change notification settings - Fork 107
refactor: Upgrade expo-server-sdk from 3.15.0 to 4.0.0 #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: Upgrade expo-server-sdk from 3.15.0 to 4.0.0 #439
Conversation
Snyk has created this PR to upgrade expo-server-sdk from 3.15.0 to 4.0.0. See this package in npm: expo-server-sdk See this project in Snyk: https://app.snyk.io/org/acinader/project/b0adf7a4-b021-4a61-8d76-16d0d77d4062?utm_source=github&utm_medium=referral&page=upgrade-pr
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughUpdated dependency version in package.json: expo-server-sdk bumped from 3.15.0 to 4.0.0. No other files or configurations changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1351 1351
=========================================
Hits 1351 1351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
(1 hunks)
🔇 Additional comments (1)
package.json (1)
29-29
: Confirm expo-server-sdk import style and CI Node target
- Imports: found named ESM imports — import { Expo } from 'expo-server-sdk' — in src/EXPO.js and spec/EXPO.spec.js; matches expo-server-sdk v4 ESM usage, so no API rename expected.
- CI/toolchain: workflow search failed in the prior run; verify CI matrices and toolchain files (.github/workflows, .nvmrc, .tool-versions, package.json) to ensure the targeted Node version is compatible (e.g., Node 18 if required).
@@ -26,7 +26,7 @@ | |||
"dependencies": { | |||
"@parse/node-apn": "6.5.0", | |||
"@parse/node-gcm": "1.0.2", | |||
"expo-server-sdk": "3.15.0", | |||
"expo-server-sdk": "4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Breaking: expo-server-sdk v4 drops Node 18; engines still allow 18 — align or postpone upgrade.
Upgrading to expo-server-sdk 4.0.0 drops support for Node v18.x. Your package.json still advertises Node "18 || 20 || 22", which can yield CI/runtime failures for users on Node 18. Either:
- Drop Node 18 in engines and CI (preferred if you’re ready to deprecate 18), or
- Postpone to the latest 3.x and keep Node 18 support.
Release note: “4.0.0 (2025-08-18) — Drop support for Node v18.x.” (newreleases.io)
Proposed diff (Option A: drop Node 18 to match dependency):
"dependencies": {
"@parse/node-apn": "6.5.0",
"@parse/node-gcm": "1.0.2",
"expo-server-sdk": "4.0.0",
"firebase-admin": "13.5.0",
"npmlog": "7.0.1",
"parse": "6.1.1",
"web-push": "3.6.7"
},
"devDependencies": {
@@
},
"engines": {
- "node": "18 || 20 || 22"
+ "node": "20 || 22"
}
Alternative (Option B: keep Node 18; defer upgrade):
- "expo-server-sdk": "4.0.0",
+ "expo-server-sdk": "3.15.0",
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"expo-server-sdk": "4.0.0", | |
"dependencies": { | |
"@parse/node-apn": "6.5.0", | |
"@parse/node-gcm": "1.0.2", | |
"expo-server-sdk": "4.0.0", | |
"firebase-admin": "13.5.0", | |
"npmlog": "7.0.1", | |
"parse": "6.1.1", | |
"web-push": "3.6.7" | |
}, | |
"engines": { | |
"node": "20 || 22" | |
} |
"expo-server-sdk": "4.0.0", | |
"dependencies": { | |
"@parse/node-apn": "6.5.0", | |
"@parse/node-gcm": "1.0.2", | |
"expo-server-sdk": "3.15.0", | |
"firebase-admin": "13.5.0", | |
"npmlog": "7.0.1", | |
"parse": "6.1.1", | |
"web-push": "3.6.7" | |
} |
🤖 Prompt for AI Agents
In package.json around line 29, the dependency bump to "expo-server-sdk":
"4.0.0" conflicts with your engines declaration allowing Node 18 (v4 drops Node
18 support); either align engines to remove Node 18 or revert the dependency to
a 3.x release. To fix: choose Option A — update the "engines" field and any CI
matrix to remove Node 18 (keep "20 || 22" or similar) and run CI locally to
confirm; or Option B — change the dependency back to the latest 3.x version in
package.json and update lockfile (npm/yarn install) so Node 18 remains
supported. Ensure the chosen option is applied consistently in package.json and
CI configs and commit the lockfile update.
Snyk has created this PR to upgrade expo-server-sdk from 3.15.0 to 4.0.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 24 days ago.
Release notes
Package name: expo-server-sdk
4.0.0 (2025-08-18)
⚠ BREAKING CHANGES
Bug Fixes
yarn build
(c953efb)Miscellaneous Chores
3.15.0 (2025-04-23)
Features
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
Summary by CodeRabbit