-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push module: warning logs about Memory leak #93
Comments
|
Duplicate #90 |
I am getting the same |
I'm starting to see this recently.. Any updates to this.. I'm running the latest parse server 2.7.4 |
I did some testing on the latest parse server release |
This is probably an issue with the node apn module, and therefore the push adapter |
@flovilmart So you mean this should be reported to node-apn? Maybe this will be resolved with node apn 3.0 release. This might take some time though. Until then I do not want to run |
That’s quite unrelated, the emitter and leaks, but your call. 2.7.4 has been out for a while, and I’m not sure anything will be done in node apn for this issue as they are moving to a native http2 implementation. Also, you can use any version of the push adapter you like! |
So you suggest using the 2.7.4 parse Server version with an older version of the push adapter by explicitly setting this in my package.json? |
Yep, and passing it into your ParseServer constructor, setting it in the package.json won’t automatically pick it up |
@funkenstrahlen are you able to get it working (with 2.7.4 and setting an older version of push adapter in package.json)? I'm unsure how to pass the apn adapter in the |
@refre5h you can do it this way:
Does it help? |
@flovilmart I got the server running with your sample, tyvm! But I'm still getting the |
@refre5h the package was renamed from npm install --save parse-server-push-adapter@1.3.0 const { ParsePushAdapter } = require('parse-server-push-adapter');
const pushAdapter = new ParsePushAdapter(pushOptions);
... |
@flovilmart That clear things up! I'm having the server running for a couple hours now, and I don't see any memory leak issue after sending numerous push. Thanks again! |
@refre5h what version are you running now? |
"parse-server": "^2.7.4", node -v // v6.12.2 ...and I used your sample codes above in my index.js. |
Ok and using the newest alpha versions of the adapter alongside node 8 with the latest release? Any feedback? |
I currently run
It does not leak memory and runs fine for me for about 2 weeks now (regarding push notifications). I have not enabled auto clearing of bad device tokens yet. I chose to try the alpha release of the push adapter because |
Thanks for the feedback. The next release of parse server will be for node 8 minimum. It’s about time :) |
Hi @funkenstrahlen , I was having memory leak issues and decided to use 3.0.0 push-adapter like you suggested. Just wondering if you had any more memory issue after you switched to the newer version of push-adapter? Thank you! p.s. for those who wanna switch to push-adapter 3.0.0, make sure you have node version > 8.11.1 otherwise your parse server will throw an error of "no http2 module found". I previously had node 6 so when I upgraded push-adapter, the server died. |
Hi @flovilmart ,
I updated with newest version.
I got warning:
Warning: Possible EventEmitter memory leak detected. 11 wakeup listeners added. Use emitter.setMaxListeners() to increase limit
Thanks.
The text was updated successfully, but these errors were encountered: