fix: Notifications fade out erratically when executing a script on large number of rows #2822

mtrezza · 2025-05-25T12:31:07Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Notifications fade out erratically when executing a script on large number of rows

Approach

Remove delayed fade-out timeout on multiple notifications.

Summary by CodeRabbit

Bug Fixes
- Improved reliability of notification hiding by ensuring timers are managed more consistently.

parse-github-assistant · 2025-05-25T12:31:10Z

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

coderabbitai · 2025-05-25T12:31:14Z

📝 Walkthrough

Walkthrough

The change refactors the timeout management logic in the notification component. It consolidates multiple clearTimeout calls into a single call just before setting a new timeout, ensuring timeouts are cleared only once before scheduling the notification hide action.

Changes

File	Change Summary
src/dashboard/Data/Browser/Notification.react.js	Refactored notification timeout logic by consolidating `clearTimeout` calls into a single call

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NotificationComponent

    User->>NotificationComponent: Receives new note props
    NotificationComponent->>NotificationComponent: Check if note differs from last note
    NotificationComponent->>NotificationComponent: Update state if needed
    NotificationComponent->>NotificationComponent: clearTimeout(existing timeout)
    NotificationComponent->>NotificationComponent: setTimeout(hide notification after 3s)

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/npm/-/npm-10.9.2.tgz failed, reason: C05C4148FC7E0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-25T12_32_10_265Z-debug-0.log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

parseplatformorg · 2025-05-25T12:31:19Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/dashboard/Data/Browser/Notification.react.js (1)
48-48: LGTM! Good fix for the timeout race condition.

Consolidating the clearTimeout call to a single point right before setting the new timeout effectively prevents race conditions that could cause erratic notification behavior when multiple notifications arrive rapidly during script execution.

This should resolve the issue where notifications were fading out unpredictably when processing large datasets.

Consider migrating from the deprecated componentWillReceiveProps to componentDidUpdate or React hooks in a future refactor:
- componentWillReceiveProps(nextProps) {
+ componentDidUpdate(prevProps) {
+   const nextProps = this.props;
   if (this.state.lastNote !== nextProps.note) {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 380bad2 and ed83588.

📒 Files selected for processing (1)

src/dashboard/Data/Browser/Notification.react.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Docker linux/amd64

# [7.2.0-alpha.8](7.2.0-alpha.7...7.2.0-alpha.8) (2025-05-25) ### Bug Fixes * Notifications fade out erratically when executing a script on large number of rows ([#2822](#2822)) ([3891381](3891381))

parseplatformorg · 2025-05-25T12:37:17Z

🎉 This change has been released in version 7.2.0-alpha.8

fix

ed83588

mtrezza changed the title ~~fix: Notifications fading out erratically when executing a script on large number of rows~~ fix: Notifications fade out erratically when executing a script on large number of rows May 25, 2025

coderabbitai bot reviewed May 25, 2025

View reviewed changes

coderabbitai bot approved these changes May 25, 2025

View reviewed changes

mtrezza merged commit 3891381 into parse-community:alpha May 25, 2025
10 of 11 checks passed

mtrezza deleted the fix/notifications-fading branch May 25, 2025 12:35

parseplatformorg added the state:released-alpha Released as alpha version label May 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Notifications fade out erratically when executing a script on large number of rows #2822

fix: Notifications fade out erratically when executing a script on large number of rows #2822

Uh oh!

mtrezza commented May 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

parse-github-assistant bot commented May 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 25, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

parseplatformorg commented May 25, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

parseplatformorg commented May 25, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Notifications fade out erratically when executing a script on large number of rows #2822

fix: Notifications fade out erratically when executing a script on large number of rows #2822

Uh oh!

Conversation

mtrezza commented May 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

Summary by CodeRabbit

Uh oh!

parse-github-assistant bot commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

parseplatformorg commented May 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parseplatformorg commented May 25, 2025

Uh oh!

Uh oh!

mtrezza commented May 25, 2025 •

edited by coderabbitai bot

Loading

parse-github-assistant bot commented May 25, 2025 •

edited

Loading

coderabbitai bot commented May 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)