-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: Data loading indicator not showing when using pagination #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Data loading indicator not showing when using pagination #2768
Conversation
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Uffizzi Ephemeral Environment
|
# [7.1.0-alpha.11](7.1.0-alpha.10...7.1.0-alpha.11) (2025-04-28) ### Bug Fixes * Data loading indicator not showing when using pagination ([#2768](#2768)) ([62d7aec](62d7aec))
🎉 This change has been released in version 7.1.0-alpha.11 |
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce explicit management of a loading state within the data fetching logic of the data browser. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DataBrowser
participant DataBrowserTable
participant DataBrowserHeaderBar
User->>DataBrowser: Initiate page navigation
DataBrowser->>DataBrowser: Set isLoading = true, data = null
DataBrowser->>DataBrowser: Fetch data
DataBrowser->>DataBrowserTable: Pass isLoading prop
DataBrowserTable->>DataBrowserHeaderBar: Pass isDataLoaded = !isLoading
DataBrowser-->>User: (UI shows loading indicator)
DataBrowser->>DataBrowser: On fetch complete, set isLoading = false, set data
DataBrowser->>DataBrowserTable: Pass isLoading = false
DataBrowserTable->>DataBrowserHeaderBar: Pass isDataLoaded = true
DataBrowser-->>User: (UI shows loaded data)
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New Pull Request Checklist
Issue Description
Closes: #2718
Approach
TODOs before merging
Summary by CodeRabbit
New Features
Bug Fixes