-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add workspace with vite project for v2 dashboard #2540
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
I will reformat the title to use the proper commit message syntax. |
Uffizzi Ephemeral Environment
|
@mtrezza will uffizzi deployment update with new commit? |
It will update if you close and re-open the PR. Takes a few minutes though. |
Uffizzi Ephemeral Environment
|
347c970
to
261155f
Compare
Uffizzi Ephemeral Environment
|
@mtrezza can you explain why we have trailing slash at the end of proxy_pass for /location inside nginx-uffizzi\nginx.conf Can we remove it as it is constricting wrong URL. For my case it's actually giving me problem when I'm hitting /dashboard/v2 as this will be treated as /dashboard//v2. |
Uffizzi Ephemeral Environment
|
Removing the slash at the end will prevent nginx from normalizing the URL. But in this case we have the same path
Since we maintain the base path anyway. Would that work for your setup as well? |
@mtrezza what I noticed is that even after removing the slash at the end the deployment is still not working. I even have checked with the same compose file in my local and it was working fine. I don't think that it will prevent nginx from normalizing the URL. As I can see in nginx docs, its more related to the location path and not the proxy_pass path. |
Uffizzi Ephemeral Environment
|
I don't think you can just remove the slash. Did you try my previous comment? Alternatively you could wrote a conditional proxy pass for the v2:
|
@mtrezza I have removed it from the nginx config and redeployed but I'm facing the same issue and I think it might be because the changes to that file is not reflecting else how can I able reproduce the same issue in my local and was able to solve it just by removing the trailing slash. I'm using the same docker compose file for docker. |
I assume the nginx changes need to be merged before they apply here. |
@mtrezza can u do it for me. Removing trailing slash works as well as ur suggested way of removing whole /dashboard/ in the end like location /dashboard {
proxy_pass http://localhost:4040;
} Whichever you prefer can you get it merged so we can finally see the preview on uffizzi deployment. |
Done #2542 |
Signed-off-by: patelmilanun <20059797+patelmilanun@users.noreply.github.com>
Uffizzi Ephemeral Environment
|
@mtrezza its working now u can check here https://pr-2540-deployment-49311-parse-dashboard.app.uffizzi.com/dashboard/v2. Thanks for the quick help. Now just need to fix test cases as we are using a custom font styling for displaying "Where we are serving the dashboard at". Another one is what is the issue with npm lock file version? Why its failing? I'm planning to move the whole app to 1 next js server removing the need of custom express. This still needs to be analyzed and then I can move forward. 1 more thing, right now this is using only workspace feature for managing this in better way I might integrate monorepo. Either I will move whole thing to next js with monorepo or just monorepos which will reduce the deployment time. I also want to check to see if we can utilize vercel for our deployment previews if I'm converting to next js. Let me know your thoughts |
Great!
Fixed in #2543; I suggest you start with the lockfile from the alpha branch and install all dependencies again; rather than trying to merge changes.
Some community feedback may be helpful. Such high level / strategic questions are best to be posted on the issue rather than the PR.
Keep in mind that we have an automated release process (semantic release) with 2 pre-release branches (alpha, beta). Any changes should be tested with the release process, and this may add quite some complexity or even outright prevent certain setups. For any monorepo setup we'd use npm workspaces, which is the tech across Parse Platform org. |
Uffizzi Ephemeral Environment
|
@patelmilanun How's it going with this PR? Do you need any help? |
New Pull Request Checklist
Issue Description
Old dashboard is outdated.
Closes: #2460
Approach
Implement modern dashboard with modern libraries.
TODOs before merging