Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add column name to related records #2264

Merged
merged 4 commits into from
Sep 17, 2022
Merged

feat: add column name to related records #2264

merged 4 commits into from
Sep 17, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 14, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

Related records can be hard to tell what field it is relating to. Especially difficult if a class has multiple pointers of the same column type

Related issue: #2191
Closes: #2191

Approach

Adds field name in related records

TODOs before merging

  • Add tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 14, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Sep 14, 2022

Could you add a screenshot how this looks like?

@dblythy
Copy link
Member Author

dblythy commented Sep 14, 2022

Screen Shot 2022-09-14 at 7 28 44 pm

@mtrezza
Copy link
Member

mtrezza commented Sep 14, 2022 •
edited
Loading

I just tried it out with a long list and it becomes more difficult to quickly find a class in the list because it's now a lot of text.

Is it possible to visually differentiate the class name from the field name?
For example, by making the field name text color less prominent:

image

I assume most classes usually have only 1 entry in the list anyway, so the field name is in most cases unnecessary information.

The same approach is used in the column header (although I don't think this low of a contrast is accessibility compliant):

image

@mtrezza mtrezza linked an issue Sep 14, 2022 that may be closed by this pull request
Related records in context menu ambiguous #2191
Closed
4 tasks
@dblythy
Copy link
Member Author

dblythy commented Sep 14, 2022

I will see what I can do

@mtrezza
Copy link
Member

mtrezza commented Sep 14, 2022 •
edited
Loading

Maybe a <span style="..."> tag? I tried to add it, but it's written as is to the list item. So there's probably some encoding logic that needs to be changed. If it's not possible we can also merge as it and improve that at a later time.

@dblythy
Copy link
Member Author

dblythy commented Sep 17, 2022

Screen Shot 2022-09-17 at 5 53 19 pm

@dblythy dblythy requested a review from a team September 17, 2022 08:09
mtrezza
mtrezza approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Nicely done with the color style

@mtrezza mtrezza merged commit cc82533 into parse-community:alpha Sep 17, 2022
@mtrezza mtrezza removed the request for review from a team September 17, 2022 11:34
parseplatformorg pushed a commit that referenced this pull request Sep 17, 2022
@semantic-release-bot
chore(release): 4.2.0-alpha.13 [skip ci]
e1d8e5b 
# [4.2.0-alpha.13](4.2.0-alpha.12...4.2.0-alpha.13) (2022-09-17)

### Features

* add column name to related records ([#2264](#2264)) ([cc82533](cc82533))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.13

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 17, 2022
@dblythy dblythy deleted the context branch September 17, 2022 12:36
parseplatformorg pushed a commit that referenced this pull request Sep 27, 2022
@semantic-release-bot
chore(release): 4.2.0-beta.2 [skip ci]
260d2b2 
# [4.2.0-beta.2](4.2.0-beta.1...4.2.0-beta.2) (2022-09-27)

### Bug Fixes

* column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a))
* context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8))
* dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857))
* file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340))
* login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91))
* unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684))
* view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7))

### Features

* add column name to related records ([#2264](#2264)) ([cc82533](cc82533))
* add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a))
* add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f))
* apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb))
* auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705))
* show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 27, 2022
parseplatformorg pushed a commit that referenced this pull request Oct 15, 2022
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
b37dd56 
# [4.2.0](4.1.4...4.2.0) (2022-10-15)

### Bug Fixes

* button text "Show all" in column menu is truncated ([#2208](#2208)) ([b89d044](b89d044))
* column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a))
* context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8))
* dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857))
* file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340))
* login fails with error `req.session.regenerate is not a function` ([#2195](#2195)) [skip release] ([31a2b78](31a2b78))
* login fails with error `req.session.regenerate is not a function` ([#2197](#2197)) [skip release] ([014d9c1](014d9c1))
* login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91))
* security upgrade terser from 5.10.0 to 5.14.2 ([#2222](#2222)) ([645cfdd](645cfdd))
* unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684))
* view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7))

### Features

* add column name to related records ([#2264](#2264)) ([cc82533](cc82533))
* add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a))
* add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f))
* apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb))
* auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705))
* improve button labels to be more concise in text ([#2207](#2207)) ([230fc14](230fc14))
* remove support and documentation links ([#2203](#2203)) ([35e4476](35e4476))
* show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 15, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Oct 20, 2022
@cycqitianwushuge
Merge branch 'release'
a5a0c67 
* release: (74 commits)
  chore(release): 4.2.0 [skip ci]
  chore(release): 4.2.0-beta.2 [skip ci]
  chore(release): 4.2.0-alpha.17 [skip ci]
  fix: view relation dialog requires browser refresh when navigating (parse-community#2275)
  chore(release): 4.2.0-alpha.16 [skip ci]
  fix: file upload dialog in data browser shows multiple times (parse-community#2276)
  chore(release): 4.2.0-alpha.15 [skip ci]
  fix: context menu in data browser is not scrollable (parse-community#2271)
  chore(release): 4.2.0-alpha.14 [skip ci]
  feat: show skeleton as loading indicator in data browser while data is loading (parse-community#2273)
  chore(release): 4.2.0-alpha.13 [skip ci]
  feat: add column name to related records (parse-community#2264)
  refactor: bump scss-tokenizer and node-sass (parse-community#2267)
  ci: bump environment (parse-community#2266)
  chore(release): 4.2.0-alpha.12 [skip ci]
  feat: auto-submit one-time password (OTP) after entering (parse-community#2257)
  chore(release): 4.2.0-alpha.11 [skip ci]
  fix: column names in data browser menu not left-aligned (parse-community#2263)
  chore(release): 4.2.0-alpha.10 [skip ci]
  docs: add node 18 support badge to README
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Related records in context menu ambiguous
3 participants
@dblythy @mtrezza @parseplatformorg