ci: refactor lint CI task and fix lint issues #2004

RaschidJFR · 2022-01-18T02:14:11Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Currently, the commands npm test and npm run lint are failing: some files are not following style rules and there are some outdated test cases.

Approach

Lint-fix all files
Update outdated test cases to pass
Add unit testing to CI workflow

TODOs before merging

Add tests
~~Add changes to documentation (guides, repository pages, in-code descriptions)~~
A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

parse-github-assistant · 2022-01-18T02:14:23Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

release.config.js

src/dashboard/Data/Browser/Browser.react.js

.github/workflows/ci.yml

package.json

RaschidJFR · 2022-01-20T06:29:01Z

I need a hand here with the CI step Lint (I should rename it in case it stays). It is failing to import .css files. I believe it may be something related to babel. I'm not too familiar, so I'd appreciate pointing me in the right direction. Meanwhile, I'll start googling around.

…score (parse-community#2036)

# [4.0.0-alpha.16](parse-community/parse-dashboard@4.0.0-alpha.15...4.0.0-alpha.16) (2022-02-10) ### Bug Fixes * adding internal class (e.g. `_User`) fails due to prefixed underscore ([parse-community#2036](parse-community#2036)) ([f80bd07](parse-community@f80bd07))

…y#2039)

…2047)

# [4.0.0-alpha.17](parse-community/parse-dashboard@4.0.0-alpha.16...4.0.0-alpha.17) (2022-02-23) ### Bug Fixes * security upgrade prismjs from 1.26.0 to 1.27.0 ([parse-community#2047](parse-community#2047)) ([3afb24e](parse-community@3afb24e))

…ty#2048)

Snyk has created this PR to upgrade @babel/runtime from 7.17.0 to 7.17.2. See this package in npm: https://www.npmjs.com/package/@babel/runtime See this project in Snyk: https://app.snyk.io/org/acinader/project/3e039b91-2450-4b56-8420-baf56cab388e?utm_source=github&utm_medium=referral&page=upgrade-pr

RaschidJFR · 2022-03-11T23:16:01Z

@mtrezza It looks like the parse SDK cannot be loaded by Jest in Node v16, causing several tests to fail. However, this doesn't seem related to the SDK package itself (all tests passing OK in v16)

So far, the only workaround I found is to use the flag --unhandled-rejections in package.json (see https://developer.ibm.com/blogs/nodejs-15-release-blog/).

Let me know your thoughts. If you find it ok, we're ready to merge.

mtrezza · 2022-03-12T16:18:50Z

It's likely that we have some unhandled rejections, I remember we have (had?) this issue in Parse Server as well.

mtrezza · 2022-03-14T08:24:05Z

The only issue I see with adding the flag is that it may obscure issues with unhandled rejections. Especially since we are running tests, I am not sure whether it makes sense to run them in a non-representative environment. We may see tests pass, but dashboard won't actually run in certain Node environments.

How about the Parse JS SDK, in which Node versions do its CI tests run?

RaschidJFR · 2022-03-14T19:36:57Z

I think you’re right. The SDK CI is running on v14. Should we drop support for v16 until the SDK officially supports it?

mtrezza · 2022-03-14T20:01:45Z

I think that would be the process. Do you want to open a PR in the JS SDK and add Node 16 to the CI? Once it runs on Node 16, we could continue here without any errors hopefully.

RaschidJFR · 2022-03-16T19:00:33Z

Finally fixed. No need to modify the SDK repo. It was enough to mock the module idb-keyval from the SDK.

mtrezza · 2022-03-23T13:41:13Z

I hope I resolved the conflicts correctly in package-lock. Let's see whether it passes.

mtrezza · 2022-03-23T13:43:05Z

@RaschidJFR Could you take a last look before merge, since this has been stale for some days.

Note to myself:

add Lint CI job as required after merging

RaschidJFR · 2022-03-23T15:37:27Z

LGTM. Thanks @mtrezza

parseplatformorg · 2022-03-24T00:09:22Z

🎉 This change has been released in version 4.1.0-alpha.2

RaschidJFR added 4 commits January 17, 2022 19:42

chore(vscode): add Jest types

e08ed25

style(*): fix lint errors

15db771

test(*): update failing tests

bcebbb8

chore(workflows): add step check-jest

286b6c7

RaschidJFR changed the title ~~chore: lint files and update test cases~~ ci: lint files and update test cases Jan 18, 2022

mtrezza reviewed Jan 18, 2022

View reviewed changes

release.config.js Show resolved Hide resolved

mtrezza reviewed Jan 18, 2022

View reviewed changes

src/dashboard/Data/Browser/Browser.react.js Show resolved Hide resolved

mtrezza reviewed Jan 18, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

RaschidJFR mentioned this pull request Jan 18, 2022

fix: cannot save nullish values for required fields #2003

Merged

5 tasks

mtrezza reviewed Jan 18, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

Merge branch 'alpha' into bugfix/fix_lint_and_tests

9a41ea2

mtrezza and others added 17 commits February 8, 2022 01:03

ci: bump environment

174ea3e

bump node

fdf5eb2

ci: bump environment (parse-community#2034)

7bfdad4

fix: adding internal class (e.g. _User) fails due to prefixed under…

f80bd07

…score (parse-community#2036)

refactor: bump follow-redirects from 1.14.7 to 1.14.8 (parse-communit…

1798179

…y#2039)

refactor: upgrade typescript from 4.5.4 to 4.5.5 (parse-community#2038)

a0720a6

refactor: bump node-sass from 6.0.1 to 7.0.0 (parse-community#2037)

9ddc98d

refactor: upgrade otpauth from 7.0.9 to 7.0.10 (parse-community#2044)

3a3e5e7

refactor: upgrade graphql from 16.2.0 to 16.3.0 (parse-community#2043)

57c4870

ci: run unit tests in 'check-build'; readd 'check-lint'

67e8cfc

chore(jest): configure to map '.css' and avoid failing

2cd948a

Merge branch 'alpha' into bugfix/fix_lint_and_tests

bea131d

fix: security upgrade prismjs from 1.26.0 to 1.27.0 (parse-community#…

3afb24e

…2047)

refactor: upgrade @babel/runtime from 7.16.7 to 7.17.0 (parse-communi…

0e819c6

…ty#2048)

Merge branch 'alpha' into bugfix/fix_lint_and_tests

7b4e89b

RaschidJFR changed the title ~~ci: lint files and update test cases~~ ci: re-enable unit tests Mar 12, 2022

mtrezza added the state:on-hold label Mar 14, 2022

parse-github-assistant bot removed the state:on-hold label Mar 14, 2022

parse-community deleted a comment from parse-github-assistant bot Mar 14, 2022

RaschidJFR added 2 commits March 16, 2022 12:33

test(*): mock module 'idb-keyval' to support tests in Node v16

2fee2e9

test(jest): mock module 'idb-keyval' locally instead of globally

2961719

mtrezza force-pushed the alpha branch from 12b61b7 to 7a3e8c7 Compare March 23, 2022 03:17

Merge branch 'alpha' into bugfix/fix_lint_and_tests

07bbf30

mtrezza approved these changes Mar 23, 2022

View reviewed changes

mtrezza changed the title ~~ci: re-enable unit tests~~ ci: add lint Mar 23, 2022

mtrezza changed the title ~~ci: add lint~~ ci: refactor lint task and fix lint issues Mar 23, 2022

mtrezza changed the title ~~ci: refactor lint task and fix lint issues~~ ci: refactor lint CI task and fix lint issues Mar 23, 2022

mtrezza merged commit fd50c08 into parse-community:alpha Mar 23, 2022

parseplatformorg added the state:released-alpha Released as alpha version label Mar 24, 2022

RaschidJFR deleted the bugfix/fix_lint_and_tests branch March 25, 2022 17:08

mtrezza pushed a commit to mtrezza/parse-dashboard that referenced this pull request Apr 3, 2022

ci: refactor lint CI task and fix lint issues (parse-community#2004)

8709ea4

mtrezza pushed a commit that referenced this pull request Apr 3, 2022

ci: refactor lint CI task and fix lint issues (#2004)

8d789db

dblythy pushed a commit to dblythy/parse-dashboard that referenced this pull request Apr 4, 2022

ci: refactor lint CI task and fix lint issues (parse-community#2004)

da457b6

snyk-bot mentioned this pull request Jul 12, 2022

refactor: upgrade js-beautify from 1.14.2 to 1.14.4 #2216

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: refactor lint CI task and fix lint issues #2004

ci: refactor lint CI task and fix lint issues #2004

RaschidJFR commented Jan 18, 2022

parse-github-assistant bot commented Jan 18, 2022 •

edited

Loading

RaschidJFR commented Jan 20, 2022

RaschidJFR commented Mar 11, 2022 •

edited

Loading

mtrezza commented Mar 12, 2022

mtrezza commented Mar 14, 2022 •

edited

Loading

RaschidJFR commented Mar 14, 2022

mtrezza commented Mar 14, 2022 •

edited

Loading

RaschidJFR commented Mar 16, 2022

mtrezza commented Mar 23, 2022

mtrezza commented Mar 23, 2022 •

edited

Loading

RaschidJFR commented Mar 23, 2022

parseplatformorg commented Mar 24, 2022

ci: refactor lint CI task and fix lint issues #2004

ci: refactor lint CI task and fix lint issues #2004

Conversation

RaschidJFR commented Jan 18, 2022

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Jan 18, 2022 • edited Loading

Thanks for opening this pull request!

RaschidJFR commented Jan 20, 2022

RaschidJFR commented Mar 11, 2022 • edited Loading

mtrezza commented Mar 12, 2022

mtrezza commented Mar 14, 2022 • edited Loading

RaschidJFR commented Mar 14, 2022

mtrezza commented Mar 14, 2022 • edited Loading

RaschidJFR commented Mar 16, 2022

mtrezza commented Mar 23, 2022

mtrezza commented Mar 23, 2022 • edited Loading

RaschidJFR commented Mar 23, 2022

parseplatformorg commented Mar 24, 2022

parse-github-assistant bot commented Jan 18, 2022 •

edited

Loading

RaschidJFR commented Mar 11, 2022 •

edited

Loading

mtrezza commented Mar 14, 2022 •

edited

Loading

mtrezza commented Mar 14, 2022 •

edited

Loading

mtrezza commented Mar 23, 2022 •

edited

Loading