-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot save nullish values for required fields #2003
fix: cannot save nullish values for required fields #2003
Conversation
Thanks for opening this pull request!
|
I'm having trouble creating the tests for So I proceeded to lint-fix all files... should I do it in this PR? |
Uh, please in an extra PR, to make it easier to review the 2 PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Is this ready for merge?
It is ready, but for the record, when the changes in #2004 are applied, the test here created will fail:
As the failure is not directly related to this PR, I think it would be a good idea to merge this now and address the problem in #2004 . |
Sounds good |
# [4.0.0-alpha.9](4.0.0-alpha.8...4.0.0-alpha.9) (2022-01-18) ### Bug Fixes * cannot save nullish values for required fields ([#2003](#2003)) ([e1a5497](e1a5497))
🎉 This change has been released in version 4.0.0-alpha.9 |
# [4.0.0-beta.3](4.0.0-beta.2...4.0.0-beta.3) (2022-02-06) ### Bug Fixes * bump follow-redirects from 1.14.4 to 1.14.7 ([#1997](#1997)) ([4ca2e97](4ca2e97)) * bump markdown-it from 12.3.0 to 12.3.2 ([#1996](#1996)) ([245c22e](245c22e)) * bump marked from 0.8.2 to 4.0.10 ([#2001](#2001)) ([ae4cc90](ae4cc90)) * bump nanoid from 3.1.28 to 3.2.0 ([#2008](#2008)) ([6cfe9ca](6cfe9ca)) * calendar widget layout partly hides last days of a month ([#1990](#1990)) ([5bd86dd](5bd86dd)) * cannot save nullish values for required fields ([#2003](#2003)) ([e1a5497](e1a5497)) * crash when checking for new dashboard release without internet connection ([#2015](#2015)) ([8c36e69](8c36e69)) * preserve column sorting preferences in data browser ([#2016](#2016)) ([c2e6557](c2e6557)) * upgrade parse from 3.4.0 to 3.4.1 ([#2011](#2011)) ([68cf9e2](68cf9e2)) * various UI bugs (e.g. filter data browser, switch app, upload file) ([#2010](#2010)) ([a508a58](a508a58))
🎉 This change has been released in version 4.0.0-beta.3 |
## [4.0.1](4.0.0...4.0.1) (2022-03-03) ### Bug Fixes * bump follow-redirects from 1.14.4 to 1.14.7 ([#1997](#1997)) ([4ca2e97](4ca2e97)) * bump markdown-it from 12.3.0 to 12.3.2 ([#1996](#1996)) ([245c22e](245c22e)) * bump marked from 0.8.2 to 4.0.10 ([#2001](#2001)) ([ae4cc90](ae4cc90)) * bump nanoid from 3.1.28 to 3.2.0 ([#2008](#2008)) ([6cfe9ca](6cfe9ca)) * calendar widget layout partly hides last days of a month ([#1990](#1990)) ([5bd86dd](5bd86dd)) * cannot save nullish values for required fields ([#2003](#2003)) ([e1a5497](e1a5497)) * crash when checking for new dashboard release without internet connection ([#2015](#2015)) ([8c36e69](8c36e69)) * preserve column sorting preferences in data browser ([#2016](#2016)) ([c2e6557](c2e6557)) * upgrade parse from 3.4.0 to 3.4.1 ([#2011](#2011)) ([68cf9e2](68cf9e2)) * various UI bugs (e.g. filter data browser, switch app, upload file) ([#2010](#2010)) ([a508a58](a508a58))
🎉 This change has been released in version 4.0.1 |
Fixes #1980
New Pull Request Checklist
Issue Description
Related issue: #1980
Approach
Instead of checking for value being nullish (eg
!value
), check for it being different fromnull
and from empty string (''
)TODOs before merging
Add changes to documentation (guides, repository pages, in-code descriptions)