Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preventSort): allow preventSort from columnPreferences props #1709

Merged
merged 2 commits into from
May 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Parse Dashboard is a standalone dashboard for managing your [Parse Server](https
* [App Icon Configuration](#app-icon-configuration)
* [App Background Color Configuration](#app-background-color-configuration)
* [Other Configuration Options](#other-configuration-options)
* [Prevent columns sorting](#prevent-columns-sorting)
* [Running as Express Middleware](#running-as-express-middleware)
* [Deploying Parse Dashboard](#deploying-parse-dashboard)
* [Preparing for Deployment](#preparing-for-deployment)
Expand Down Expand Up @@ -241,6 +242,33 @@ You can set `appNameForURL` in the config file for each app to control the url o

To change the app to production, simply set `production` to `true` in your config file. The default value is false if not specified.

### Prevent columns sorting

You can prevent some columns to be sortable by adding `preventSort` to columnPreference options in each app configuration

```json

"apps": [
{
"appId": "local_app_id",
"columnPreference": {
"_User": [
{
"name": "createdAt",
"visible": true,
"preventSort": true
},
{
"name": "updatedAt",
"visible": true,
"preventSort": false
},
]
}
}
]
```

# Running as Express Middleware

Instead of starting Parse Dashboard with the CLI, you can also run it as an [express](https://github.com/expressjs/express) middleware.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default class DataBrowserHeaderBar extends React.Component {
</div>
];

headers.forEach(({ width, name, type, targetClass, order, visible }, i) => {
headers.forEach(({ width, name, type, targetClass, order, visible, preventSort }, i) => {
if (!visible) return;
let wrapStyle = { width };
if (i % 2) {
Expand All @@ -36,15 +36,20 @@ export default class DataBrowserHeaderBar extends React.Component {
wrapStyle.background = '#66637A';
}
let onClick = null;
if (type === 'String' || type === 'Number' || type === 'Date' || type === 'Boolean') {
if (!preventSort && (type === 'String' || type === 'Number' || type === 'Date' || type === 'Boolean')) {
onClick = () => updateOrdering((order === 'descending' ? '' : '-') + name);
}

let className = styles.wrap;
if (preventSort) {
className += ` ${styles.preventSort} `;
}

elements.push(
<div
onClick={onClick}
key={'header' + i}
className={styles.wrap}
className={className}
style={ wrapStyle }>
<DataBrowserHeader
name={name}
Expand All @@ -65,7 +70,7 @@ export default class DataBrowserHeaderBar extends React.Component {
if (headers.length % 2) {
finalStyle.background = 'rgba(224,224,234,0.10)';
}

elements.push(
readonly || preventSchemaEdits ? null : (
<div key='add' className={styles.addColumn} style={finalStyle}>
Expand Down
6 changes: 6 additions & 0 deletions src/components/DataBrowserHeaderBar/DataBrowserHeaderBar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,9 @@
}
}
}

.preventSort {
:hover {
cursor: not-allowed;
}
}
7 changes: 4 additions & 3 deletions src/dashboard/Data/Browser/BrowserTable.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,15 @@ export default class BrowserTable extends React.Component {
}
}

let headers = this.props.order.map(({ name, width, visible }) => (
let headers = this.props.order.map(({ name, width, visible, preventSort }) => (
{
width: width,
name: name,
type: this.props.columns[name].type,
targetClass: this.props.columns[name].targetClass,
order: ordering.col === name ? ordering.direction : null,
visible
visible,
preventSort
}
));
let editor = null;
Expand Down Expand Up @@ -140,7 +141,7 @@ export default class BrowserTable extends React.Component {
setRelation={this.props.setRelation}
setCopyableValue={this.props.setCopyableValue}
setContextMenu={this.props.setContextMenu}
onEditSelectedRow={this.props.onEditSelectedRow}
onEditSelectedRow={this.props.onEditSelectedRow}
/>
<Button
value="Add"
Expand Down