Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Release v2.0.5 #1357

Merged
merged 1 commit into from
Oct 24, 2019
Merged

⚡️ Release v2.0.5 #1357

merged 1 commit into from
Oct 24, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 24, 2019

Update Package Lock file to handle dependencies (corejs3).

CoreJS is no longer a dev dependency 👇
https://github.com/parse-community/parse-dashboard/compare/2.0.5?expand=1#diff-32607347f8126e6534ebc7ebaec4853dR917

@dplewis dplewis requested a review from acinader October 24, 2019 19:16
@dplewis
Copy link
Member Author

dplewis commented Oct 24, 2019

@acinader Can you pull it down and see if it works?

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works for me.

worth noting that after running npm installl, the package-lock was dirty. My assumption is that that is a due to a change in parse-server where we always get latest, so we'll see changes if there are andy dependency changes there....

@dplewis
Copy link
Member Author

dplewis commented Oct 24, 2019

I alway assumed that for parse-server for example although package.json points to the latest. package-lock should point to a specific commit (that commit will get update if you regenerate package-lock.json).

@dplewis dplewis merged commit 9684a24 into master Oct 24, 2019
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Oct 27, 2019
* parse:
  ⚡️ Release v2.0.5 (parse-community#1357)

# Conflicts:
#	package-lock.json
@TomWFox TomWFox deleted the 2.0.5 branch February 27, 2020 21:46
@TomWFox TomWFox linked an issue Feb 27, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM Install Issue
2 participants