Skip to content

Undocumented regexp matching is confusing #2153

Open
@mathieulb

Description

@mathieulb

New Issue Checklist

Issue Description

"string contains string" actually uses Parse.Query's .matches(str,'i') specifier, which is not documented and can cause problems because various punctuation has special meaning in regexps. However, as regexps are also very useful, it would be best to keep this feature while renaming it "matches" or "matches regexp" or "matches pattern" or "regexp" or "pattern", while also have a separate choice called "contains" or "contains substring", which would match a regexp produced by :

function escapeRegex(s:string):string {
    return s.replace(/[-\\^$*+?.()|[\]{}]/g, '\\$&')
}

Steps to reproduce

Filter a string field with a "string contains string" clause (in any version of Dashboard in which it still works, e.g. 4.0.0) ; search using a . in place of any specific character, which will find your items anyway ; then try searching for ( in a string column that has that character : searching for \( finds those items even though no \ is in that column, and searching for literally ( finds 0 results.

Actual Outcome

"string contains string" searches for regexp.

Expected Outcome

"string contains string" would search for a substring, another option would search for provided regexp.

Environment

Dashboard

  • Parse Dashboard version: 4.0.0
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Firefox 100.0.1

Server

  • Parse Server version: 5.2.0
  • Operating system: Heroku-20
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Heroku

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: Unknown
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): ObjectRocket at Heroku

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:featureNew feature or improvement of existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions