-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image doesn't work anymore with the MFA feature #1787
Comments
Thanks for opening this issue!
|
We would have to make a 3.0 release as bumping the min node version is breaking. a) How could we have prevented this issue?
But would that have prevented this? b) How do we resolve this issue?
@Klaitos may I ask out of curiosity, how do you use the |
Hello @mtrezza, I'm not surprise for a For your b) i think it's a good idea to release a last stable version of parse-dashboard 2.x without MFA and node 12. For your a) i need to think more about it. |
Anything below node 12 has actually reached its EOL, so we wouldn't even offer LTS for a dashboard 2.x version; we already do not support anything below node 12 for Parse Server. You discovered an interesting case that is not yet covered by our CI, if there is a way to prevent this, I'd like to add it to our CI. So the plan is:
|
The build is ok, the issue is at runtime. I have nothing related to MFA in the config file. |
node 10 is the new minimal. See #1788 (comment) |
Got it, that's why the builds were pushed successfully. So we need a CI step that ensures that we don't have a dependency that requires a higher node engine than the parent package. |
closed via #1788 |
Any chance to have 2.2 or recent tag uploaded to the docker hub ? i do not want to use latest anymore for now, but 2.0.5 is quite old :) |
I think we can do that, if you want to open just a short new issue so we don't forget. |
New Issue Checklist
Issue Description
The merge of the MFA feature #1624 add some dependencies which need node 12 at leat. The docker image is built over node 8. The container can't be run anymore.
Steps to reproduce
Actual Outcome
Expected Outcome
Environment
Dashboard
FILL_THIS_OUT
FILL_THIS_OUT
FILL_THIS_OUT
Server
FILL_THIS_OUT
FILL_THIS_OUT
FILL_THIS_OUT
Database
FILL_THIS_OUT
FILL_THIS_OUT
FILL_THIS_OUT
Logs
The text was updated successfully, but these errors were encountered: