Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image doesn't work anymore with the MFA feature #1787

Closed
4 tasks done
Klaitos opened this issue Sep 8, 2021 · 12 comments
Closed
4 tasks done

Docker image doesn't work anymore with the MFA feature #1787

Klaitos opened this issue Sep 8, 2021 · 12 comments

Comments

@Klaitos
Copy link
Contributor

Klaitos commented Sep 8, 2021

New Issue Checklist

Issue Description

The merge of the MFA feature #1624 add some dependencies which need node 12 at leat. The docker image is built over node 8. The container can't be run anymore.

Steps to reproduce

Actual Outcome

Expected Outcome

Environment

Dashboard

  • Parse Dashboard version: FILL_THIS_OUT
  • Browser (Safari, Chrome, Firefox, Edge, etc.): FILL_THIS_OUT
  • Browser version: FILL_THIS_OUT

Server

  • Parse Server version: FILL_THIS_OUT
  • Operating system: FILL_THIS_OUT
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): FILL_THIS_OUT

Database

  • System (MongoDB or Postgres): FILL_THIS_OUT
  • Database version: FILL_THIS_OUT
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): FILL_THIS_OUT

Logs

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your issue will be closed. If a field does not apply to the issue, fill in n/a.

@mtrezza
Copy link
Member

mtrezza commented Sep 8, 2021

We would have to make a 3.0 release as bumping the min node version is breaking.

a) How could we have prevented this issue?
Our CI needs a multi-environment setup, like parse server. Currently in dashboard:

  • the PR CI runs only on node 10.14
  • the release CI only on node 12
  • the package min node ver is 8.9

But would that have prevented this?

b) How do we resolve this issue?
Maybe an opportunity to start a LTS trial also for dashboard

  1. branch out dashboard before MFA merge and release 2.x
  2. update master with MFA and release 3.0

@Klaitos may I ask out of curiosity, how do you use the latest docker tag, or what do you assume it means? because latest in npm means "latest stable", but dashboard currently uses the latest tag on docker hub as "latest unstable / working branch", which may be confusing.

@Klaitos
Copy link
Contributor Author

Klaitos commented Sep 8, 2021

Hello @mtrezza,

I'm not surprise for a latest tag to be buggy, it was my mistake to use it in my docker-compose. I fixed my compose to stick the version to 2.0.5 to prevent future issues.

For your b) i think it's a good idea to release a last stable version of parse-dashboard 2.x without MFA and node 12.

For your a) i need to think more about it.

@mtrezza
Copy link
Member

mtrezza commented Sep 8, 2021

Anything below node 12 has actually reached its EOL, so we wouldn't even offer LTS for a dashboard 2.x version; we already do not support anything below node 12 for Parse Server. You discovered an interesting case that is not yet covered by our CI, if there is a way to prevent this, I'd like to add it to our CI.

So the plan is:

  1. Update our CI to find a way to prevent this, at least with multiple node versions
  2. Bump min node version to 12
  3. Release dashboard 3.0

@mtrezza mtrezza mentioned this issue Sep 8, 2021
4 tasks
@mtrezza
Copy link
Member

mtrezza commented Sep 8, 2021

The docker image is built over node 8. The container can't be run anymore.

@Klaitos How did you encounter the error? I am trying to foresee that in the CI with #1789, but the docker builds without issues. Was this a node runtime error when you tried to use the MFA feature?

@Klaitos
Copy link
Contributor Author

Klaitos commented Sep 8, 2021

Just try to run the container without any option.
docker run -p 8080:4040 -v "/path/to/parsedashboard.json:/src/Parse-Dashboard/parse-dashboard-config.json" parseplatform/parse-dashboard:latest

Capture d’écran 2021-09-08 à 18 31 53

And with node 12 (built on my laptop) :

Capture d’écran 2021-09-08 à 18 32 19

@Klaitos
Copy link
Contributor Author

Klaitos commented Sep 8, 2021

The build is ok, the issue is at runtime. I have nothing related to MFA in the config file.

@Klaitos
Copy link
Contributor Author

Klaitos commented Sep 8, 2021

node 10 is the new minimal. See #1788 (comment)

@mtrezza
Copy link
Member

mtrezza commented Sep 8, 2021

Got it, that's why the builds were pushed successfully. So we need a CI step that ensures that we don't have a dependency that requires a higher node engine than the parent package.

@mtrezza
Copy link
Member

mtrezza commented Sep 8, 2021

closed via #1788

@mtrezza mtrezza closed this as completed Sep 8, 2021
@Klaitos
Copy link
Contributor Author

Klaitos commented Sep 8, 2021

Any chance to have 2.2 or recent tag uploaded to the docker hub ? i do not want to use latest anymore for now, but 2.0.5 is quite old :)

@mtrezza
Copy link
Member

mtrezza commented Sep 9, 2021

I think we can do that, if you want to open just a short new issue so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants