Un-hidden columns contain empty fields

[mtrezza]

Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Dashboard!

• You're running version >=1.0.23 of Parse Dashboard.
• You're running version >=2.3.2 of Parse Server.
• You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Issue

The PR #1694 excluded hidden columns from being fetched from the server. When showing previously hidden columns, the values for the un-hidden fields are (undefined), because their values have not been fetched. Clicking the "Reset" button loads the fields.

Instructions

1. Hide a column with values
2. Click "Reload"
3. Un-hide column --> fields are empty
4. Click "Reload" --> fields contain values

[sadakchap]

Thanks @mtrezza for detailed instruction to reproduce the issue. But, I still could not reproduce the issue. could you please check below gif & tell me which step I am missing ?

Steps I followed -

1. Hide a column with values
2. Hit refresh button
3. Un-hide that column --> still can see the values

[mtrezza]

You did it correctly. Could you try to create a new column and repeat it with that? Maybe it only happens for certain columns.

[sadakchap]

Still was not able to reproduce the issue.

[mtrezza]

This is what I see on Safari. Note that without refreshing, the column contains data after un-hiding it. But after refreshing, it does not contain data when un-hiding it. I am using branch 2a4479a.

I think the simple question is, if columns a not fetched when they are hidden, how would the data show in the column after un-hiding it? Or does un-hiding a column trigger a query?

Screen.Recording.2021-05-29.at.16.34.39.mov

[fn-faisal]

I tried to reproduce this on Chrome, Safari browsers but could not reproduce this. I tried the master branch and the commit but can't reproduce this.
It would be helpful if we had some more information regarding this like the devtools console, network request response for the refresh call.
Thank you.

[davimacedo]

What do you guys think about automatically refreshing the data everytime a new column is marked as visible?

[mtrezza]

Yes, that was my previous question:

I think the simple question is (...) does un-hiding a column trigger a query?

I tested with current masters of parse server (parse-community/parse-server@0638e5e) and parse dashboard (b044768) with Safari and Chrome (both not in private mode). Server and dashboard run locally and the dashboard runs with npm run dev. In the browser console a column hiding or unhiding does not seem to trigger a server request.

If that is the case, then the video in #1716 (comment) does not make sense, because where would the data come from. @sadakchap can you confirm that there is no server request when the column is unhidden?

[sadakchap]

Yes, no server request is going when the column is unhidden.

Please see the above gif.

1. Hit refresh button, 1 server request is made. (no column is hidden)
2. Hide column ( username is hidden )
3. Hit refresh, 1 server request is again made.( please notice that this request still gives value of hidden column )
4. Unhide the column, column still has values

[sadakchap]

@mtrezza, I tried to add a breakpoint before exclude query. Please see the below gif.

1. added a breakpoint, cleared the localstorage(as this is where we store column preference)
2. Hit refresh for the first time ( no column is hidden till now )
3. Hide a column, here we got key on localstorage which has hidden column visible set to false.
4. Hit refresh, see at breakpoint columns is still null.

From above gif, I think maybe some problem in getting column preference from localstorage as it is always null and query.exclude never got executed resulting in a request which is fetching all details.

Could you please try to reproduce this issue after clearing localstorage.

[sadakchap]

I think it is clear from above video, that we are unable to get columns from local storage. Here's the pr #1734 for that.

[mtrezza]

Yes, no server request is going when the column is unhidden.

Well, I think that is the simple explanation, isn't it? Where would the column data come from if a previous query excluded the field.

Hit refresh, 1 server request is again made.( please notice that this request still gives value of hidden column )

The request should exclude the field, so that should not happen. That was the point of #1694. If you cannot reproduce the issue, you may not be using the current master branch where the PR has been merged.

[sadakchap]

Well, I think that is the simple explanation, isn't it? Where would the column data come from if a previous query excluded the field.

Yes but, the previous request actually never excluded the field. Please refer the video above once more. You can see the Network tab.

The request should exclude the field, so that should not happen. That was the point of #1694. If you cannot reproduce the issue, you may not be using the current master branch where the PR has been merged.

I think I am using latest master branch. I also had put a debugger, you can see the code, it's from master branch.
Honestly I never reviewed this #1694, I don't know why field is not getting excluded in request.