Skip to content

Commit 52bba62

Browse files
author
Damian Stasik
authored
fix: Data browser dialog "No data to display" may be outside of visible area in Safari browser (#2387)
1 parent dc18f7e commit 52bba62

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

src/dashboard/Data/Browser/Browser.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@
1515
bottom: 0;
1616
overflow: auto;
1717
padding-top: 30px;
18-
// fix for safari scrolling issue:
19-
// https://css-tricks.com/forums/topic/safari-for-ios-z-index-ordering-bug-while-scrolling-a-page-with-a-fixed-element/
20-
// only applying to safari as a side effect of this is emptystate component centering is off
21-
&.safari {
22-
-webkit-transform: translate3d(0,0,0);
23-
}
2418
}
2519

2620
body:global(.expanded) {

src/dashboard/Data/Browser/BrowserTable.react.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* the root directory of this source tree.
77
*/
88
import BrowserRow from 'components/BrowserRow/BrowserRow.react';
9-
import * as browserUtils from 'lib/browserUtils';
109
import DataBrowserHeaderBar from 'components/DataBrowserHeaderBar/DataBrowserHeaderBar.react';
1110
import Editor from 'dashboard/Data/Browser/Editor.react';
1211
import EmptyState from 'components/EmptyState/EmptyState.react';
@@ -429,7 +428,7 @@ export default class BrowserTable extends React.Component {
429428
}
430429

431430
return (
432-
<div className={[styles.browser, browserUtils.isSafari() ? styles.safari : ''].join(' ')}>
431+
<div className={styles.browser}>
433432
{table}
434433
<DataBrowserHeaderBar
435434
selected={

src/lib/browserUtils.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
* the root directory of this source tree.
77
*/
88

9-
export function isSafari() {
10-
return /Safari/.test(navigator.userAgent) && /Apple Computer/.test(navigator.vendor);
11-
}
12-
139
export function isChrome() {
1410
return /Chrome/.test(navigator.userAgent) && /Google Inc/.test(navigator.vendor);
1511
}

0 commit comments

Comments
 (0)