Skip to content

Safely call close on the websocket client with synchronized calls #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2018

Conversation

mmimeault
Copy link
Contributor

#82

@mmimeault mmimeault requested a review from rogerhu April 16, 2018 14:57
flovilmart
flovilmart previously approved these changes Apr 16, 2018
Copy link

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concurrency is hard 👍

@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #83 into master will increase coverage by 3.76%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage      68.2%   71.96%   +3.76%     
- Complexity       82       84       +2     
============================================
  Files            11       11              
  Lines           368      371       +3     
  Branches         24       25       +1     
============================================
+ Hits            251      267      +16     
+ Misses          103       88      -15     
- Partials         14       16       +2
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/parse/ParseLiveQueryClientImpl.java 75.7% <ø> (ø) 56 <0> (ø) ⬇️
...ain/java/com/parse/OkHttp3SocketClientFactory.java 32.65% <25%> (+32.65%) 2 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c39de0...d07f392. Read the comment docs.

@mmimeault mmimeault merged commit 8bfbe76 into master Apr 16, 2018
@mmimeault mmimeault deleted the bugfix/issue-82-crash-client branch April 16, 2018 15:56
@mmimeault mmimeault removed the request for review from rogerhu April 16, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants