Skip to content

Commit d7b1c8e

Browse files
authored
fix: Parse.setServer doesn't properly validate URL (#1844)
1 parent e947529 commit d7b1c8e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme

-3
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,6 @@
9696
<Test
9797
Identifier = "ParseClientConfigurationTests/testExtensionDataSharing">
9898
</Test>
99-
<Test
100-
Identifier = "ParseClientConfigurationTests/testServerValidation">
101-
</Test>
10299
</SkippedTests>
103100
</TestableReference>
104101
</Testables>

Parse/Parse/Source/ParseClientConfiguration.m

+2-1
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,9 @@ - (void)setClientKey:(NSString *)clientKey {
6969
}
7070

7171
- (void)setServer:(NSString *)server {
72+
NSURL *url = [NSURL URLWithString:server];
7273
PFParameterAssert(server.length, @"Server should not be `nil`.");
73-
PFParameterAssert([NSURL URLWithString:server], @"Server should be a valid URL.");
74+
PFParameterAssert(url && url.scheme && url.host, @"Server should be a valid URL.");
7475
_server = [server copy];
7576
}
7677

0 commit comments

Comments
 (0)