Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WithinPolygon to Query #438

Merged
merged 6 commits into from
Jun 20, 2017
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 31, 2017

I added support for querying within polygon on the latest server update

parse-community/parse-server#3866

Let me know if I should add more tests.

Sometimes errors when I run test I get a lot of these errors

Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

I don't think my objects are getting delete before and after each it() test

@codecov
Copy link

codecov bot commented Jun 2, 2017

Codecov Report

Merging #438 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   85.35%   85.34%   -0.02%     
==========================================
  Files          46       46              
  Lines        3702     3704       +2     
  Branches      846      846              
==========================================
+ Hits         3160     3161       +1     
- Misses        542      543       +1
Impacted Files Coverage Δ
src/ParseQuery.js 94.54% <0%> (-0.58%) ⬇️
src/ParseFile.js 82.35% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b5296...f02c5d0. Read the comment docs.

@flovilmart
Copy link
Contributor

@dplewis yes the objects are not cleared as the test objects are just created once for the spec. Could you update the tests so they are using the

      let sacramento = new TestPoint();
      sacramento.set('location', new Parse.GeoPoint(38.52, -121.50));
      sacramento.set('name', 'Sacramento');

      let honolulu = new TestPoint();
      honolulu.set('location', new Parse.GeoPoint(21.35, -157.93));
      honolulu.set('name', 'Honolulu');

      let sf = new TestPoint();
      sf.set('location', new Parse.GeoPoint(37.75, -122.68));
      sf.set('name', 'San Francisco');

This way, your tests will just reuse the fixtures already used.

@dplewis
Copy link
Member Author

dplewis commented Jun 20, 2017

sorry for the late reply tests are working

@flovilmart
Copy link
Contributor

LGTM! Thanks!

@flovilmart flovilmart merged commit 1b26adc into parse-community:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants