Skip to content

fix: subscription to a LiveQuery containing ParseQuery.select overrides properties #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2022
Merged

fix: subscription to a LiveQuery containing ParseQuery.select overrides properties #1488

merged 5 commits into from
Jul 2, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jun 5, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

When using .select with LQ, the Parse JS SDK strips out all keys on objects that have the same reference.

Related issue: #1487

Approach

If .select is used in the LQ query, don't set all keys to undefined.

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 5, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jun 5, 2022 •
edited
Loading

Codecov Report

Merging #1488 (ccec21a) into alpha (e5420ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ccec21a differs from pull request most recent head 13f5b6c. Consider uploading reports for the commit 13f5b6c to get more accurate results

@@           Coverage Diff           @@
##            alpha    #1488   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5954     5955    +1     
  Branches     1357     1358    +1     
=======================================
+ Hits         5951     5952    +1     
  Misses          3        3
Impacted Files Coverage Δ
src/LiveQueryClient.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5420ff...13f5b6c. Read the comment docs.

@dblythy dblythy requested a review from a team June 5, 2022 11:41
@mtrezza mtrezza changed the title fix: prevent LiveQuery override with query.select fix: prevent LiveQuery override with query.select Jun 5, 2022
@mtrezza mtrezza changed the title fix: prevent LiveQuery override with query.select fix: prevent LiveQuery override with Parse.Query.select Jun 5, 2022
@mtrezza mtrezza changed the title fix: prevent LiveQuery override with Parse.Query.select fix: prevent LiveQuery override with ParseQuery.select Jun 5, 2022
@mtrezza mtrezza changed the title fix: prevent LiveQuery override with ParseQuery.select fix: LiveQuery overrides properties when using ParseQuery.select Jun 5, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: LiveQuery overrides properties when using ParseQuery.select fix: liveQuery overrides properties when using ParseQuery.select Jun 5, 2022
@mtrezza mtrezza changed the title fix: liveQuery overrides properties when using ParseQuery.select fix: subscribing to a LiveQuery containing ParseQuery.select overrides properties Jun 5, 2022
@mtrezza mtrezza changed the title fix: subscribing to a LiveQuery containing ParseQuery.select overrides properties fix: subscription to a LiveQuery containing ParseQuery.select overrides properties Jun 5, 2022
@mtrezza mtrezza linked an issue Jul 2, 2022 that may be closed by this pull request
Keys are stripped upon subscription update with LiveQuery.select #1487
Closed
4 tasks
mtrezza
mtrezza approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; waiting or #1487 (comment) to resolve before merge

@mtrezza mtrezza merged commit b80eee4 into parse-community:alpha Jul 2, 2022
parseplatformorg pushed a commit that referenced this pull request Jul 2, 2022
@semantic-release-bot
chore(release): 3.4.3-alpha.3 [skip ci]
e205623 
## [3.4.3-alpha.3](3.4.3-alpha.2...3.4.3-alpha.3) (2022-07-02)

### Bug Fixes

* subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([#1488](#1488)) ([b80eee4](b80eee4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.3-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 2, 2022
@dblythy dblythy deleted the fix-query branch July 2, 2022 13:33
@dblythy
Copy link
Member Author

dblythy commented Jul 2, 2022

Thanks all!

parseplatformorg pushed a commit that referenced this pull request Jul 2, 2022
@semantic-release-bot
chore(release): 3.4.4-beta.1 [skip ci]
fc79281 
## [3.4.4-beta.1](3.4.3...3.4.4-beta.1) (2022-07-02)

### Bug Fixes

* subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([#1488](#1488)) ([b80eee4](b80eee4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.4-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jul 2, 2022
parseplatformorg pushed a commit that referenced this pull request Jul 28, 2022
@semantic-release-bot
chore(release): 3.4.4-alpha.1 [skip ci]
200f4b7 
## [3.4.4-alpha.1](3.4.3...3.4.4-alpha.1) (2022-07-28)

### Bug Fixes

* creating a Parse.File with base64 string fails for some encodings ([#1517](#1517)) ([0439862](0439862))
* subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([#1488](#1488)) ([b80eee4](b80eee4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.4-alpha.1

parseplatformorg pushed a commit that referenced this pull request Sep 2, 2022
@semantic-release-bot
chore(release): 3.4.4 [skip ci]
0712abd 
## [3.4.4](3.4.3...3.4.4) (2022-09-02)

### Bug Fixes

* subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([#1488](#1488)) ([b80eee4](b80eee4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.4

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 2, 2022
jpgupta pushed a commit to jpgupta/Parse-SDK-JS-UUID-Update that referenced this pull request Oct 24, 2022
@dblythy @jpgupta
fix: subscription to a LiveQuery containing ParseQuery.select overr…
3e855f6 
…ides properties (parse-community#1488)
jpgupta pushed a commit to jpgupta/Parse-SDK-JS-UUID-Update that referenced this pull request Oct 24, 2022
@semantic-release-bot @jpgupta
chore(release): 3.4.3-alpha.3 [skip ci]
72210f0 
## [3.4.3-alpha.3](parse-community/Parse-SDK-JS@3.4.3-alpha.2...3.4.3-alpha.3) (2022-07-02)

### Bug Fixes

* subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([parse-community#1488](parse-community#1488)) ([b80eee4](parse-community@b80eee4))
jpgupta pushed a commit to jpgupta/Parse-SDK-JS-UUID-Update that referenced this pull request Oct 24, 2022
@semantic-release-bot @jpgupta
chore(release): 3.4.4-beta.1 [skip ci]
384e83d 
## [3.4.4-beta.1](parse-community/Parse-SDK-JS@3.4.3...3.4.4-beta.1) (2022-07-02)

### Bug Fixes

* subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([parse-community#1488](parse-community#1488)) ([b80eee4](parse-community@b80eee4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keys are stripped upon subscription update with LiveQuery.select
3 participants
@dblythy @parseplatformorg @mtrezza