Skip to content

Fix react native build #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

davimacedo
Copy link
Member

Improve #1351

@davimacedo davimacedo requested a review from dplewis July 6, 2021 07:14
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1381 (acf7e49) into master (0bd120e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1381   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          61       61           
  Lines        5941     5943    +2     
  Branches     1349     1350    +1     
=======================================
+ Hits         5888     5890    +2     
  Misses         52       52           
  Partials        1        1           
Impacted Files Coverage Δ
src/EventEmitter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd120e...acf7e49. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dplewis dplewis merged commit 886f17d into parse-community:master Jul 7, 2021
@davimacedo
Copy link
Member Author

@dplewis @mtrezza I'd like to release this fix. Do you think there is any break change here that we need to wait for Parse Server release before releasing the SDK?

@mtrezza
Copy link
Member

mtrezza commented Jul 7, 2021

If there was a breaking change, wouldn't the tests fail with 4.5.0? Maybe test it from both sides, the SDK with 4.5.0 and Parse Server with the JS SDK master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants