-
-
Notifications
You must be signed in to change notification settings - Fork 597
Added date support to OfflineQuery class #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm sorry but im not sure what im doing wrong... |
npm version issue maybe? used 7 downgrading to 6 now, maybe that will help... |
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 99.94% 99.23% -0.71%
==========================================
Files 60 60
Lines 5847 5919 +72
Branches 1311 1346 +35
==========================================
+ Hits 5844 5874 +30
- Misses 3 44 +41
- Partials 0 1 +1
Continue to review full report at Codecov.
|
@dplewis Maybe we want the NPM version CI check in the JS SDK as well? |
sure, actually don't know how to do that tho... |
No worries, we'll add it in another PR so that others can identify the issue easier when they are building with npm 7. I hand this PR back to @dplewis for review, haven't looked into the details so far, but all tests pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If you want you could include this in LiveQuery
https://github.com/parse-community/parse-server/blob/master/src/LiveQuery/QueryTools.js
Hopefully this fixes the issues iv had with package-lock.json file.
Added date support to OfflineQuery class
this enables you to use $relativeTime in local data store mode the same way you can use it via normal parseQuery.