Generate installationId as UUID (#972)

Author: dplewis

src/InstallationController.js

@@ -10,25 +10,10 @@
  */
 
 import Storage from './Storage';
+const uuidv4 = require('uuid/v4');
 
 let iidCache = null;
 
-function hexOctet() {
-  return Math.floor(
-    (1 + Math.random()) * 0x10000
-  ).toString(16).substring(1);
-}
-
-function generateId() {
-  return (
-    hexOctet() + hexOctet() + '-' +
-    hexOctet() + '-' +
-    hexOctet() + '-' +
-    hexOctet() + '-' +
-    hexOctet() + hexOctet() + hexOctet()
-  );
-}
-
 const InstallationController = {
   currentInstallationId(): Promise<string> {
     if (typeof iidCache === 'string') {
@@ -37,7 +22,7 @@ const InstallationController = {
     const path = Storage.generatePath('installationId');
     return Storage.getItemAsync(path).then((iid) => {
       if (!iid) {
-        iid = generateId();
+        iid = uuidv4();
         return Storage.setItemAsync(path, iid).then(() => {
           iidCache = iid;
           return iid;

src/__tests__/InstallationController-test.js

@@ -11,6 +11,10 @@ jest.dontMock('../CoreManager');
 jest.dontMock('../InstallationController');
 jest.dontMock('../Storage');
 jest.dontMock('../StorageController.default');
+jest.mock('uuid/v4', () => {
+  let value = 0;
+  return () => value++ + '';
+});
 
 const CoreManager = require('../CoreManager');
 const InstallationController = require('../InstallationController');