Skip to content

Changed endpoint classes/_User to users #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Kiwifed0r
Copy link
Contributor

Change the old endpoint classes/_User to users in order to make it consistent.

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #717   +/-   ##
========================================
  Coverage        53%     53%           
  Complexity     1732    1732           
========================================
  Files           132     132           
  Lines         10266   10266           
  Branches       1434    1434           
========================================
  Hits           5441    5441           
  Misses         4376    4376           
  Partials        449     449
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/parse/ParseRESTUserCommand.java 93.93% <ø> (ø) 13 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3639523...5bfbf73. Read the comment docs.

@Jawnnypoo
Copy link
Member

Looks like this will be backwards compatible, right? It affects the sign up process?
http://docs.parseplatform.org/rest/guide/#signing-up

@Kiwifed0r
Copy link
Contributor Author

@Jawnnypoo iOS and JavaScript use this endpoint for sign up, so this should be backwards compatible. It basically just fixes a legacy issue in the Parse-Android-SDK

Copy link
Member

@Jawnnypoo Jawnnypoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogerhu rogerhu merged commit a69d994 into parse-community:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants