Skip to content

Add missing User-Agent header. #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2017
Merged

Add missing User-Agent header. #651

merged 1 commit into from
May 2, 2017

Conversation

aontas
Copy link
Contributor

@aontas aontas commented May 2, 2017

When moving to OKHTTP3, the User-Agent header was not added to the set of headers sent to the interceptor. It previously was there.

This simply re-adds it so that it is the same as it was before.

@codecov
Copy link

codecov bot commented May 2, 2017

Codecov Report

Merging #651 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #651      +/-   ##
============================================
- Coverage     52.86%   52.86%   -0.01%     
  Complexity     1676     1676              
============================================
  Files           131      131              
  Lines         10146    10147       +1     
  Branches       1408     1408              
============================================
  Hits           5364     5364              
- Misses         4339     4340       +1     
  Partials        443      443
Impacted Files Coverage Δ Complexity Δ
Parse/src/main/java/com/parse/ParsePlugins.java 43.29% <0%> (-0.46%) 12 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80f25f...7380a85. Read the comment docs.

@rogerhu
Copy link
Contributor

rogerhu commented May 2, 2017

Thanks somehow it got deleted in 6cfc4a0

@rogerhu
Copy link
Contributor

rogerhu commented May 2, 2017

Are there any other headers too?

@rogerhu rogerhu merged commit 8873597 into parse-community:master May 2, 2017
@aontas
Copy link
Contributor Author

aontas commented May 3, 2017

The HEADER_OS_VERSION also seems to be missing.

bradserbuddy pushed a commit to bradserbuddy/Parse-SDK-Android that referenced this pull request May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants