Migrate all icons to SVG and remove Carbon icons

[josefinalliende]

🤯 Problem

There was some confusion around our icon usage. We’ve been switching some icons to Carbon, but Carbon icons actually loads all the library, as @erskingardner had warned us before. So the current situation is

• Some icons are Carbon (CarbonIcons.something)
• Some are material app icons (Icon.something)
• Some icons are svg

💡 Solution

• All carbon icons should be replaced by svgs.
• Carbon icons should be removed

👣 Solution Steps

• Identify all Carbon icons currently in use
• Replace them with equivalent SVGs
• Remove carbon icons imports
• Replace also material icons with svgs
• Replace pngs icons with svgs

[erskingardner]

YES! Love this.

[josefinalliende]

YES! Love this.

Hahah that was fast to read 😅 I was still editing when you answered I think, added a doubt at the end in case you didn't see it

[josefinalliende]

Doubt resolved in signal,material app icons also should be replaced by svgs

[josefinalliende]

To update here what was talked in the chat: finally the reason of this change is more for consistency than for loading too many icons, cause apparently tree shaking 🌳 🫨 would solve that on build ...

[untreu2]

@josefinalliende BTW, I want to clarify this point. Flutter does not include icons that we do not use in the build. Don't you think it is enough to just convert carbon icons to SVG? and if i'm not wrong, @vladimir-krstic doesn't use any material icons in Figma. So if we are using a material icon, we should replace it with its carbon icon equivalent, right?

[untreu2]

So my suggestion is to do this only for carbon icons for now.

[vladimir-krstic]

@untreu2 where do we user material icons? 😱 Pretty sure I haven't seen any in UI.

I don't understand Carbon vs. SVG. Carbon publishes only SVGs, they don't do PNGs or font icons.

Still It would be better that we export icons from Figma and use those for few reasons:

• to keep icon library smaller.
• because I make new icons and adapt some that don't fit our needs.
• eventually we would want to update the names of most of the icons to describe better what we use them for.

[josefinalliende]

@josefinalliende BTW, I want to clarify this point. Flutter does not include icons that we do not use in the build. Don't you think it is enough to just convert carbon icons to SVG? and if i'm not wrong, @vladimir-krstic doesn't use any material icons in Figma. So if we are using a material icon, we should replace it with its carbon icon equivalent, right?

Sorry I've just seen this reply. So I guess you finally changed material icons too, cause now I don't found anythong with the syntax of Icon.something