fix multiple users without keypackage ux bug (#453)

* fix multiple users without keypackage ux bug

* update

* evaluate and fix creation logic

Author: codeswot

lib/ui/contact_list/group_chat_details_sheet.dart

@@ -4,6 +4,7 @@ import 'package:flutter_screenutil/flutter_screenutil.dart';
 import 'package:flutter_svg/svg.dart';
 import 'package:gap/gap.dart';
 import 'package:go_router/go_router.dart';
+import 'package:logging/logging.dart';
 import 'package:whitenoise/config/providers/active_account_provider.dart';
 import 'package:whitenoise/config/providers/group_provider.dart';
 import 'package:whitenoise/domain/models/contact_model.dart';
@@ -57,13 +58,11 @@ class _GroupChatDetailsSheetState extends ConsumerState<GroupChatDetailsSheet> w
   bool _hasGroupImage = false;
   bool _isGroupNameValid = false;
   bool _isCreatingGroup = false;
-  bool _hasContactsWithKeyPackage = true;
 
   @override
   void initState() {
     super.initState();
     _groupNameController.addListener(_onGroupNameChanged);
-    _checkContactsKeyPackages();
   }
 
   void _onGroupNameChanged() {
@@ -75,36 +74,12 @@ class _GroupChatDetailsSheetState extends ConsumerState<GroupChatDetailsSheet> w
     }
   }
 
-  Future<void> _checkContactsKeyPackages() async {
-    try {
-      final filteredContacts = await _filterContactsByKeyPackage(widget.selectedContacts);
-      if (!mounted) return;
-
-      final contactsWithKeyPackage = filteredContacts['withKeyPackage']!;
-
-      if (mounted) {
-        setState(() {
-          _hasContactsWithKeyPackage = contactsWithKeyPackage.isNotEmpty;
-        });
-      }
-    } catch (e) {
-      // If there's an error checking keypackages, assume no contacts have keypackages
-      if (mounted) {
-        setState(() {
-          _hasContactsWithKeyPackage = false;
-        });
-      }
-    }
-  }
-
   void _createGroupChat() async {
-    if (!_isGroupNameValid) return;
-    final groupName = _groupNameController.text.trim();
+    if (!_isGroupNameValid || !mounted) return;
 
-    // Store the ref early to avoid accessing it after disposal
+    final groupName = _groupNameController.text.trim();
     final notifier = ref.read(groupsProvider.notifier);
 
-    if (!mounted) return;
     setState(() {
       _isCreatingGroup = true;
     });
@@ -117,13 +92,25 @@ class _GroupChatDetailsSheetState extends ConsumerState<GroupChatDetailsSheet> w
       final contactsWithKeyPackage = filteredContacts['withKeyPackage']!;
       final contactsWithoutKeyPackage = filteredContacts['withoutKeyPackage']!;
 
-      if (contactsWithKeyPackage.isEmpty) {
-        safeShowErrorToast('No contacts have keypackages available for group creation');
+      // If less than 2 contacts have keypackages, only show invite sheet (no group creation)
+      if (contactsWithKeyPackage.length < 2) {
+        if (contactsWithoutKeyPackage.isNotEmpty && mounted) {
+          await ShareInviteBottomSheet.show(
+            context: context,
+            contacts: contactsWithoutKeyPackage,
+          );
+        }
+
+        if (mounted) {
+          context.pop();
+        }
         return;
       }
 
-      // Create group with contacts that have keypackages - use stored notifier
-      final groupData = await notifier.createNewGroup(
+      // Create group with contacts that have keypackages
+      if (!mounted) return;
+
+      final createdGroupData = await notifier.createNewGroup(
         groupName: groupName,
         groupDescription: '',
         memberPublicKeyHexs: contactsWithKeyPackage.map((c) => c.publicKey).toList(),
@@ -132,58 +119,50 @@ class _GroupChatDetailsSheetState extends ConsumerState<GroupChatDetailsSheet> w
 
       if (!mounted) return;
 
-      GroupData? successGroupData;
-      String? errorMessage;
-
-      if (groupData != null) {
-        successGroupData = groupData;
+      if (createdGroupData != null) {
         // Show share invite bottom sheet for members without keypackages
         if (contactsWithoutKeyPackage.isNotEmpty && mounted) {
-          await ShareInviteBottomSheet.show(
-            context: context,
-            contacts: contactsWithoutKeyPackage,
-          );
+          try {
+            await ShareInviteBottomSheet.show(
+              context: context,
+              contacts: contactsWithoutKeyPackage,
+            );
+          } catch (e) {
+            Logger(
+              'GroupChatDetailsSheet',
+            ).severe('Error showing share invite bottom sheet: $e');
+          }
         }
-      } else {
-        errorMessage = 'Failed to create group chat. Please try again.';
-      }
-
-      // Complete all local operations first
-      if (mounted) {
-        setState(() {
-          _isCreatingGroup = false;
-        });
-      }
 
-      // Show error if needed
-      if (errorMessage != null) {
-        safeShowErrorToast(errorMessage);
-      }
+        // Navigate to the created group
+        if (mounted) {
+          context.pop();
 
-      if (successGroupData != null && mounted) {
-        // Navigate to home first, then to the group chat
-        WidgetsBinding.instance.addPostFrameCallback((_) {
-          if (mounted) {
-            context.pop();
-            context.go(Routes.home);
-            WidgetsBinding.instance.addPostFrameCallback((_) {
+          WidgetsBinding.instance.addPostFrameCallback((_) async {
+            if (mounted) {
+              context.go(Routes.home);
+              // Small delay to ensure navigation completes
+              await Future.delayed(const Duration(milliseconds: 150));
               if (mounted) {
-                Routes.goToChat(context, groupData!.mlsGroupId);
+                Routes.goToChat(context, createdGroupData.mlsGroupId);
               }
-            });
-          }
-        });
+            }
+          });
+        }
+      } else {
+        safeShowErrorToast('Failed to create group chat. Please try again.');
       }
-
-      return;
     } catch (e) {
+      if (mounted) {
+        safeShowErrorToast('Error creating group: ${e.toString()}');
+      }
+    } finally {
+      // Always reset loading state
       if (mounted) {
         setState(() {
           _isCreatingGroup = false;
         });
       }
-      safeShowErrorToast('Error creating group: ${e.toString()}');
-      return;
     }
   }
 
@@ -319,10 +298,7 @@ class _GroupChatDetailsSheetState extends ConsumerState<GroupChatDetailsSheet> w
           ),
         ),
         WnFilledButton(
-          onPressed:
-              _isCreatingGroup || !_isGroupNameValid || !_hasContactsWithKeyPackage
-                  ? null
-                  : () => _createGroupChat(),
+          onPressed: _isCreatingGroup || !_isGroupNameValid ? null : _createGroupChat,
           loading: _isCreatingGroup,
           title: _isCreatingGroup ? 'Creating Group...' : 'Create Group',
         ),

lib/ui/contact_list/share_invite_bottom_sheet.dart

@@ -41,29 +41,26 @@ class ShareInviteBottomSheet extends ConsumerStatefulWidget {
 class _ShareInviteBottomSheetState extends ConsumerState<ShareInviteBottomSheet> {
   @override
   Widget build(BuildContext context) {
+    if (widget.contacts.isEmpty) {
+      return const SizedBox.shrink();
+    }
     final isSingleContact = widget.contacts.length == 1;
-    final contact = isSingleContact ? widget.contacts.first : null;
-    if (contact == null) return const SizedBox.shrink();
+    final singleContact = widget.contacts.first;
 
     return Column(
       mainAxisSize: MainAxisSize.min,
       children: [
         if (isSingleContact) ...[
-          // Single contact view
-          Column(
-            children: [
-              Gap(12.h),
-              UserProfile(
-                imageUrl: contact.imagePath ?? '',
-                name: contact.displayName,
-                nip05: contact.nip05 ?? '',
-                pubkey: contact.publicKey,
-                ref: ref,
-              ),
-              Gap(36.h),
-              ShareInviteCallout(contact: contact),
-            ],
+          Gap(12.h),
+          UserProfile(
+            imageUrl: singleContact.imagePath ?? '',
+            name: singleContact.displayName,
+            nip05: singleContact.nip05 ?? '',
+            pubkey: singleContact.publicKey,
+            ref: ref,
           ),
+          Gap(36.h),
+          ShareInviteCallout(contact: singleContact),
         ] else ...[
           // Multiple contacts view
           Padding(
@@ -80,19 +77,19 @@ class _ShareInviteBottomSheetState extends ConsumerState<ShareInviteBottomSheet>
               ],
             ),
           ),
-          // Contacts list
-          Expanded(
-            child: ListView.builder(
-              padding: EdgeInsets.symmetric(horizontal: 24.w),
-              itemCount: widget.contacts.length,
-              itemBuilder: (context, index) {
-                final contact = widget.contacts[index];
-                return ContactListTile(contact: contact);
-              },
-            ),
+
+          ListView.builder(
+            padding: EdgeInsets.symmetric(horizontal: 24.w),
+            shrinkWrap: true,
+            primary: false,
+            itemCount: widget.contacts.length,
+            itemBuilder: (context, index) {
+              final contact = widget.contacts[index];
+              return ContactListTile(contact: contact);
+            },
           ),
         ],
-        Gap(10.h),
+        Gap(14.h),
         const ShareInviteButton(),
       ],
     );