Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launching from local images in kubernetes #1830

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

th7nder
Copy link

@th7nder th7nder commented Jul 11, 2024

When launching using Kubernetes provider (zombienet -p kubernetes) and using minikube, I needed to use local image without publishing it.
I can add it to minikube, by using minikube image load image-name:tag and specify in zombienet.toml:

[settings]
image_pull_policy = "IfNotPresent"

However, it'd still fail at the creating bootnodes (and running --help commands), because the policy was to Always download images and they were not published.

Ideally, this option probably should be sourced from networkSpec.settings.image_pull_policy, but I left it at this level.

Let me know what you think!

Sort of related to #1829 (as a workaround to not having private registries)

@th7nder th7nder requested a review from pepoviola as a code owner July 11, 2024 13:41
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jul 11, 2024

User @th7nder, please sign the CLA here.

@pepoviola
Copy link
Collaborator

Hi @th7nder, thanks for the feedback. Yes, those pods should read the config from the settings in order to behave like the rest. I can make those changes to fix this.

Thanks!

@pepoviola pepoviola added the Maintenance V1 maintenance label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance V1 maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants