Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] handle correct the max_nominations related to the validators set. #733

Open
pepoviola opened this issue Feb 16, 2023 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pepoviola
Copy link
Collaborator

This config with 10 validators will try to create nominators with a max nominations of 24 (our default) and will break the chain-spec (with nulls). We should handle and set the max_nominations related to the validators set.

[settings]
timeout = 4800
bootnode = true

[relaychain.genesis.runtime.configuration.config]
  max_validators_per_core = 1
  needed_approvals = 21

[relaychain]
default_image = "{{ZOMBIENET_INTEGRATION_TEST_IMAGE}}"
chain = "kusama-local"
chain_spec_command = "polkadot build-spec --chain kusama-local --disable-default-bootnode"
default_command = "polkadot"
random_nominators_count = 250

[relaychain.default_resources]
limits = { memory = "8G", cpu = "4" }
requests = { memory = "2G", cpu = "1" }

  [[relaychain.node_groups]]
  name = "honest-validator"
  count = 8
  args = ["-lparachain=debug,runtime=debug"]

  [[relaychain.node_groups]]
  image = "{{MALUS_IMAGE}}"
  name = "malus-validator"
  command = "malus dispute-ancestor"
  args = ["--fake-validation=approval-invalid", "-lparachain=debug,MALUS=trace"]
  count = 2

{% for id in range(2000,2019) %}
[[parachains]]
id = {{id}}
addToGenesis = true
genesis_state_generator = "undying-collator export-genesis-state --pov-size={{10000*(id-1999)}} --pvf-complexity={{id - 1999}}"
    [parachains.collator]
    image = "{{COL_IMAGE}}"
    name = "collator"
    command = "undying-collator"
    args = ["-lparachain=debug", "--pov-size={{10000*(id-1999)}}", "--parachain-id={{id}}", "--pvf-complexity={{id - 1999}}"]
{% endfor %}

[types.Header]
number = "u64"
parent_hash = "Hash"
post_state = "Hash"

cc @tdimitrov

@pepoviola pepoviola added bug Something isn't working good first issue Good for newcomers labels Feb 16, 2023
@pepoviola
Copy link
Collaborator Author

Here we set the max_nominations value https://github.com/paritytech/zombienet/blob/main/javascript/packages/orchestrator/src/configGenerator.ts#L118 but we should validate it after compute the validator set.

@wirednkod wirednkod changed the title [bug] handle correct the [bug] handle correct the max_nominations related to the validators set. Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant