Repository navigation
revert(truapi)!: remove the raw proof context escape hatch - #554
Merged
Merged
Conversation
Restore product-scoped ring-VRF contexts after the temporary Humanity workaround served its purpose. Reverts #457.
Reapply the removal on the renamed truapi crate, drop the tests that only covered the raw: context, and add a major changeset for the removed export.
peetzweg
marked this pull request as ready for review
October 14, 2026 09:18
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (4)
Commit: 20d4832 |
Contributor
|
CI Status: 24 required jobs green, 21 passed and 3 skipped by path filter. All job results
Signing credentials: failure as of 2026-10-14, a release may fail Commit |
pgherveou
enabled auto-merge
October 14, 2026 11:54
Mikelle
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #457 deliberately allowed products to mint proofs in contexts they do not own so the Humanity flow could be exercised end to end. That workaround has served its purpose and must not ship as a permanent weakening of product context isolation.
This intentionally removes the exported
development_createAccountProofhelper and stops treating theraw:product marker specially.Verification
make checkRUSTFLAGS='-D warnings' cargo build --workspace --all-targets --all-featuresmake uniffi-kotlingradle :truapi-host:assembleReleasewith Gradle 8.9 and JDK 178983638bgit diff --checkReverts #457.