Skip to content

revert(truapi)!: remove the raw proof context escape hatch - #554

Merged
pgherveou merged 3 commits into
mainfrom
revert/raw-proof-context
Oct 14, 2026
Merged

pgherveou merged 3 commits into
mainfrom
revert/raw-proof-context

Conversation

@pgherveou

Copy link
Copy Markdown
Collaborator

Summary

  • remove the development-only raw ring-VRF proof context escape hatch
  • restore product-scoped context derivation at all signing and pairing call sites
  • remove the temporary TypeScript helper, tests, exports, and documentation

Why

PR #457 deliberately allowed products to mint proofs in contexts they do not own so the Humanity flow could be exercised end to end. That workaround has served its purpose and must not ship as a permanent weakening of product context isolation.

This intentionally removes the exported development_createAccountProof helper and stops treating the raw: product marker specially.

Verification

  • make check
  • RUSTFLAGS='-D warnings' cargo build --workspace --all-targets --all-features
  • make uniffi-kotlin
  • gradle :truapi-host:assembleRelease with Gradle 8.9 and JDK 17
  • exact tree match with the parent of squash commit 8983638b
  • matching stable patch IDs for the original change and its reverse
  • git diff --check

Reverts #457.

Restore product-scoped ring-VRF contexts after the temporary
Humanity workaround served its purpose.

Reverts #457.
Reapply the removal on the renamed truapi crate, drop the tests that
only covered the raw: context, and add a major changeset for the
removed export.
@peetzweg peetzweg changed the title revert: remove raw proof context escape hatch revert(truapi)!: remove the raw proof context escape hatch Oct 14, 2026
@github-actions github-actions Bot added javascript Pull requests that update javascript code rust Pull requests that update rust code labels Oct 14, 2026
@peetzweg
peetzweg marked this pull request as ready for review October 14, 2026 09:18
@peetzweg
peetzweg requested a review from a team October 14, 2026 09:18
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Compared with main at 073b4f2.

Raw Gzip Brotli
truapi-host 7.88 MiB (-77 B) 5.66 MiB (-49 B) 5.38 MiB (-117 B)
truapi-provider 4.03 MiB 1.27 MiB 960.1 KiB
truapi 6.29 MiB (-1.6 KiB) 889.7 KiB (-721 B, -0.1%) 728.6 KiB (-623 B, -0.1%)
Total 18.20 MiB (-1.7 KiB) 7.80 MiB (-770 B) 7.03 MiB (-740 B)

WebAssembly modules

Raw Gzip Brotli
truapi-host/wasm/web/truapi_server_bg.wasm 2.77 MiB (-77 B) 988.9 KiB (-49 B) 744.8 KiB (-117 B)
truapi-host/wasm/web/truapi_verifiable_bg.wasm 4.89 MiB 4.64 MiB 4.61 MiB
truapi-provider/truapi_provider_bg.wasm 3.99 MiB 1.26 MiB 952.4 KiB
Changed files (4)
Raw Gzip Brotli
truapi/development.js removed removed removed
truapi/playground/codegen/truapi-dts.js 287.4 KiB (-672 B, -0.2%) 49.7 KiB (-205 B, -0.4%) 40.1 KiB (-173 B, -0.4%)
truapi-host/wasm/web/truapi_server_bg.wasm 2.77 MiB (-77 B) 988.9 KiB (-49 B) 744.8 KiB (-117 B)
truapi/index.js 557 B (-34 B, -5.8%) 285 B (-8 B, -2.7%) 220 B (-4 B, -1.8%)

Commit: 20d4832

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

CI Status: 24 required jobs green, 21 passed and 3 skipped by path filter.

All job results
job result
android-bindings success
bundle-size success
changes success
changeset-guard success
cli-package success
codegen success
e2e skipped
explorer success
headless-install success
host-android-bindings success
host-android-detekt success
host-wasm success
ios-bindings success
ios-swift success
licenses success
playground success
provider-android-bindings skipped
release-guard success
rust success
ts-client success
ts-debugger success
ts-host success
wasm-provider success
workflow-lint skipped

Signing credentials: failure as of 2026-10-14, a release may fail

Commit 20d4832c · run log

@pgherveou
pgherveou enabled auto-merge October 14, 2026 11:54
@pgherveou
pgherveou added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit 7472b77 Oct 14, 2026
42 checks passed
@pgherveou
pgherveou deleted the revert/raw-proof-context branch October 14, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code R2 blocker Must be done for R2 rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants